From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Andy Shevchenko <andy@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH v5 00/10] General clean up and bug fixes
Date: Sun, 22 Feb 2026 21:40:10 -0600 [thread overview]
Message-ID: <20260223034020.27625-1-ethantidmore06@gmail.com> (raw)
This series performs a general cleanup of the gp2ap020a00f IIO driver.
It integrates my original work switching to the guard() cleanup handler,
fixing a signedness warning from Smatch, an error swallow bug originally
spotted by Andy Shevchenko which I expanded to cover both buffer setup
functions and general cleanups written by Andy Shevchenko [1].
v5:
- Patch 1: Integrate some of Andy Shevchenko's changes.
- Patch 4: Split patch up as requested by Andy Shevchenko.
- Patch 5: Split this patch from the patch number 4, to keep bug fix
separate from style fix.
v4:
- Integrated Andy Shevchenko's 7-patch cleanup series.
- Patch 1: Removed redundant 'err' variable and whitespace issues as
suggested by Andy.
- Patch 2: Added Reviewed-by tag from Andy Shevchenko.
- Patch 5: Updated commit message to describe the pre-existing bug fix
in gp2ap020a00f_buffer_predisable() where errors could be swallowed.
v3:
- Addressed initial feedback and simplified locking logic.
[1] https://lore.kernel.org/all/20260217102318.1354103-1-andriy.shevchenko@linux.intel.com/
Andy Shevchenko (7):
iio: light: gp2ap020a00f: Use correct types for 16-bit LE data
iio: light: gp2ap020a00f: Return directly from the switch cases
iio: light: gp2ap020a00f: Replace custom implementation of min()
iio: light: gp2ap020a00f: Use temporary variable for struct device
iio: light: gp2ap020a00f: Explicitly use string literal for driver
name
iio: light: gp2ap020a00f: Remove trailing comma in termination entry
iio: light: gp2ap020a00f: Join some lines of code to be a single line
Ethan Tidmore (3):
iio: light: gp2ap020a00f: simplify locking with guard()
iio: light: gp2ap020a00f: correct return type to int
iio: light: gp2ap020a00f: Fix possible error swallow
drivers/iio/light/gp2ap020a00f.c | 303 ++++++++++++-------------------
1 file changed, 117 insertions(+), 186 deletions(-)
--
2.53.0
next reply other threads:[~2026-02-23 3:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 3:40 Ethan Tidmore [this message]
2026-02-23 3:40 ` [PATCH v5 01/10] iio: light: gp2ap020a00f: simplify locking with guard() Ethan Tidmore
2026-02-23 11:54 ` Andy Shevchenko
2026-02-23 3:40 ` [PATCH v5 02/10] iio: light: gp2ap020a00f: correct return type to int Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 03/10] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 04/10] iio: light: gp2ap020a00f: Return directly from the switch cases Ethan Tidmore
2026-02-23 12:00 ` Andy Shevchenko
2026-02-23 3:40 ` [PATCH v5 05/10] iio: light: gp2ap020a00f: Fix possible error swallow Ethan Tidmore
2026-02-23 12:05 ` Andy Shevchenko
2026-02-23 21:15 ` Jonathan Cameron
2026-02-23 3:40 ` [PATCH v5 06/10] iio: light: gp2ap020a00f: Replace custom implementation of min() Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 07/10] iio: light: gp2ap020a00f: Use temporary variable for struct device Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 08/10] iio: light: gp2ap020a00f: Explicitly use string literal for driver name Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 09/10] iio: light: gp2ap020a00f: Remove trailing comma in termination entry Ethan Tidmore
2026-02-23 3:40 ` [PATCH v5 10/10] iio: light: gp2ap020a00f: Join some lines of code to be a single line Ethan Tidmore
2026-02-23 12:16 ` [PATCH v5 00/10] General clean up and bug fixes Andy Shevchenko
2026-02-23 12:17 ` Andy Shevchenko
2026-02-23 21:18 ` Jonathan Cameron
2026-02-24 9:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223034020.27625-1-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox