From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D2434404B for ; Mon, 23 Feb 2026 03:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818052; cv=none; b=nnEyuIpdxtevfr4R9ttqtEnaYUHzuY5r1Mb3yQ4WSMmB4NkM+vClTXXuMUEUW5HTHIZPM57gA+LL/wQuACqXxn7a0svFD2JCuvw/UwjUPbAE1mo/JABoEAu+xUGiiSo/TTsQelkFaALRZkg/ERD8BVGID1LhJ7GJnMitYqkfEeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818052; c=relaxed/simple; bh=JpgjQT0LjeiOJzmjtLe3sLwto3eScrmQ5EGl4TkpJGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NLbNGlbmkm8+G3UqnCQlf+OWGrbu7ldpcjscjo0+N/CiFl80bMk4snzxUA9QyR4vKCnqumhmmCQSLQPJUfRjEkiGcd4q3+52AK+f+UtB/b0gS7YCSaAGeq6TK1oNbRnPdBS6h3hk0KMbRTnuvXQrTsy4TLfqHMiv9UY/mrXgFxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y3eh76Xb; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y3eh76Xb" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-79495b1aaa7so32051047b3.1 for ; Sun, 22 Feb 2026 19:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771818050; x=1772422850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AODKCMIgB1Rg+62Tm7VBERUXirbCJ30DxdcOZIoJtvI=; b=Y3eh76XbvYOfTLxggvnVoAH91XmeHvlo/mNTu5t9PTI8zORZZfTBQD58mUiyysyYnz Hn7f+T21TUuu07y4mFHtUMv+8VdkbdOQdj9tjVBZS3urlPvizQUATMwAbHmFsBabWUYs s5y+HB68HO++PyYijjtZhGvq8SnUsnjmqVshWyN/Bpkt84SKBUFKdf/btHmztLXXX34s 4rw4ZMzpqFXRLdZQq5rvgVNgrxEOfKNO90vm6CArQSTS9nY+LXPYLuGeDrgapektDBan eZZUD8567kpm9AybxITnFHJb2F0fSvEWf/fTMM+5hKPL3AxKtN6RNOT0sG9PBbApGKz9 xYuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771818050; x=1772422850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AODKCMIgB1Rg+62Tm7VBERUXirbCJ30DxdcOZIoJtvI=; b=RgkYSCITFHNnbDbOgx64HVPnGyWO/c7iIzeccw9h4f/JBBCLMMQ7bNo2UPpjQJje+3 UlMfjI4poZHBxU2MglLFLhlilHIVW9xEW1Vb0PWV4Sr7zYFCMd3WX4lPcrhE6mUS/OOC jYMNan1GtkupnJAUYyTZEWDT/Q9kNusfHvSqK1lSMy8aSLHNxvW9qz9hEAWPbXTLItM5 wGuv1hLHHKh4wFewlbmWsleUBtZmYoJuNnOkGFlVMZiR3K3McBTVZxzh8sLVlhr9sQ2I UNfS1JXn4dZdEZU81V5FWW5mmXW7bD70kTyN/0wy/gjJ99TqV96MU7a2jEnAUJaFVp5v tOyw== X-Forwarded-Encrypted: i=1; AJvYcCUBX8mY6llod3aQ7ei5Bz84f0Tw5Y+mLhxCbrzluSY3RynO3o3LdoXseD81bZ2mZiR/xfhxFBFrxnmFg+s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5xVHTexPwinm+W+LS/B58ZmlvMUaRzvWadFFKzloSzwBMnYKC F3nClGDUN68G9TUxccvuItKqJIwx9LDzJFQrDuBlEpF74KrUyTg5swh8 X-Gm-Gg: ATEYQzykwW5DsKjSTnnTB8vCIuCmuJ7qBzrYeIUTUUFaTSRXk7KWl23SkqdV4NWESpA k5WlF3g4+sBPRCfp1u+6XezWdcqDZXBA/p9/zXvEWj0DpiSmhHO1DR7Tm2A8N3CnnlhrjiVcAl9 UpGKZukAQZO7iq3GIp8JXIx+4B5eEfklM+4sMv7SzEy81cj6+qL7KAeaNwOJ37BGE+39imXGerq j4yiVgFn18tSGI3QK1KwRA82NlAzGc9SV3fvrR/OAUmsbmtdH8+nWjoTMVbnnil0BhE1dxJs6Lv SaTj8Rb8kZZ5LWzlnjFXPm3zh0ZvCf0WkE6o+lTU2i9g/dcGUN3YSqRlcvbf0bK6YsG237lD/fG cu770S49XaPUNAQ5xaXx2DgTsro4AZh5F8o7hPjl5OnsjihKdCZoxXPUfYs1Amj4tt00VtAE+Cv kk7UBhveqzE1d/bZh7dn5CQ5Pgsvh5BEt5AR0tAW5DZREETgxIUtXqWWHamBfLQCoJcuUmtTvm1 6M17n1yv5rk4JsW8WVasPS/MRO4UmbbnSE= X-Received: by 2002:a05:690c:6ac6:b0:794:b8c0:5a98 with SMTP id 00721157ae682-798291a1469mr64770897b3.58.1771818049721; Sun, 22 Feb 2026 19:40:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dbd5939sm27285237b3.15.2026.02.22.19.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:40:49 -0800 (PST) From: Ethan Tidmore To: Jonathan Cameron , Andy Shevchenko Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v5 10/10] iio: light: gp2ap020a00f: Join some lines of code to be a single line Date: Sun, 22 Feb 2026 21:40:20 -0600 Message-ID: <20260223034020.27625-11-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223034020.27625-1-ethantidmore06@gmail.com> References: <20260223034020.27625-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Andy Shevchenko In some cases the wrapped lines are harder to follow. Join them despite being longer than 80 characters in some cases. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v5: - No change. v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 39 +++++++++++--------------------- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c index 0571803155ae..9d4a310f92b7 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -175,10 +175,8 @@ #define GP2AP020A00F_CHAN_TIMESTAMP 3 #define GP2AP020A00F_DATA_READY_TIMEOUT msecs_to_jiffies(1000) -#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + \ - (chan) * 2) -#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + \ - (th_val_id) * 2) +#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + (chan) * 2) +#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + (th_val_id) * 2) #define GP2AP020A00F_THRESH_VAL_ID(reg_addr) ((reg_addr - 4) / 2) #define GP2AP020A00F_SUBTRACT_MODE 0 @@ -390,20 +388,17 @@ static int gp2ap020a00f_set_operation_mode(struct gp2ap020a00f_data *data, } err = regmap_update_bits(data->regmap, GP2AP020A00F_ALS_REG, - GP2AP020A00F_PRST_MASK, opmode_regs_settings[op] - .als_reg); + GP2AP020A00F_PRST_MASK, opmode_regs_settings[op].als_reg); if (err < 0) return err; err = regmap_update_bits(data->regmap, GP2AP020A00F_PS_REG, - GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op] - .ps_reg); + GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op].ps_reg); if (err < 0) return err; err = regmap_update_bits(data->regmap, GP2AP020A00F_LED_REG, - GP2AP020A00F_PIN_MASK, opmode_regs_settings[op] - .led_reg); + GP2AP020A00F_PIN_MASK, opmode_regs_settings[op].led_reg); if (err < 0) return err; } @@ -861,8 +856,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(int irq, void *data) int thresh_val_id, ret; /* Read interrupt flags */ - ret = regmap_read(priv->regmap, GP2AP020A00F_OP_REG, - &op_reg_val); + ret = regmap_read(priv->regmap, GP2AP020A00F_OP_REG, &op_reg_val); if (ret < 0) goto done; @@ -874,8 +868,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(int irq, void *data) /* Clear interrupt flags (if not in INTTYPE_PULSE mode) */ if (priv->cur_opmode != GP2AP020A00F_OPMODE_PROX_DETECT) { - ret = regmap_write(priv->regmap, GP2AP020A00F_OP_REG, - op_reg_val); + ret = regmap_write(priv->regmap, GP2AP020A00F_OP_REG, op_reg_val); if (ret < 0) goto done; } @@ -972,8 +965,7 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq, void *data) } } - iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, - pf->timestamp); + iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, pf->timestamp); done: iio_trigger_notify_done(indio_dev->trig); @@ -1023,26 +1015,22 @@ static int gp2ap020a00f_write_event_val(struct iio_dev *indio_dev, switch (thresh_reg_l) { case GP2AP020A00F_TH_L_REG: - event_en = test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, - &data->flags); + event_en = test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags); break; case GP2AP020A00F_TL_L_REG: - event_en = test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, - &data->flags); + event_en = test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags); break; case GP2AP020A00F_PH_L_REG: if (val == 0) return -EINVAL; - event_en = test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, - &data->flags); + event_en = test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); break; case GP2AP020A00F_PL_L_REG: if (val == 0) return -EINVAL; - event_en = test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, - &data->flags); + event_en = test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); break; } @@ -1520,8 +1508,7 @@ static void gp2ap020a00f_remove(struct i2c_client *client) struct device *dev = &client->dev; int err; - err = gp2ap020a00f_set_operation_mode(data, - GP2AP020A00F_OPMODE_SHUTDOWN); + err = gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) dev_err(dev, "Failed to power off the device.\n"); -- 2.53.0