From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C4E3451B5 for ; Mon, 23 Feb 2026 03:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818048; cv=none; b=SB/Dzhchn04I7GdiiEyk0EJMsKIlO0pJd3T/EwcdT3RSQB9l7+cGwBq/5dlA1AKLD1jMx79ECyrq3AMYwz66GnoZOepSGy7Lkjt6lcvJspM0My3IK2tMWMSynjJeNP+AXThR1kPlty/hp5n0jbzltVTAd0YBllXZc4ROFe1OPhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818048; c=relaxed/simple; bh=y8vKPCubDswMfiV1BDFc/WRWFhnkHJE3yofbqLmhM6Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgA3g5uKX+CLE9BddJ6mGFA7ea4fHjq/oGu8aY6Fq2Kz2ZgQfTBF7n7f3J/7fWa/iWFWjv/Kh7Myi6QRzKBJKEn7aML6mGUo9jCxiFrp9sfipWoMdyvabFDUKoVrWePVwPzHeevxMhj0QmQPwp9Lm847sZZIgOmMbC8Dgqp3TpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b8mX5vII; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8mX5vII" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-79801df3e21so35769697b3.2 for ; Sun, 22 Feb 2026 19:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771818045; x=1772422845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8IRh4rvJW/Bj1AuQS9zzQJnQDdzxOYm3yTJBXXZTfSk=; b=b8mX5vIIP7wKcZw256qO7AvO7PSjDBcxrlh0KGv+DMHChh4rUDLFhNgYXNEGwLHbhr DfI2REHoOAZvvBrIjN+X7cI3L4840+ieYMyhGbjQgUhib48WYgvN6F2Gbw1eKYH3Y4T3 vXpcsvohHIqu+TwByTsTHgNXzKC4LyM8J1p8n+CUCBX2pGHEWFb7uW0dSLKKKZNr70M8 lK5QKmgG7KWgLWpOu93GBlmhg87Mj4oEny13YNsIT2OfCsRiVblKch3Bu81CzD0j3i1t BS0Wtx/wPH0IjyAX+gefY5yutOSTF03kv2D3a0fmWcs1LCTVOFjnGh96cmry27c4wF1E s/zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771818045; x=1772422845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8IRh4rvJW/Bj1AuQS9zzQJnQDdzxOYm3yTJBXXZTfSk=; b=VdlEnBXQnyLn+5oWmutFti9x+40GXMvKo1Blcm2B8vOlrWwZIify5ecDqdnoZ4oUJd P8n3F4o+KF/BBc6zfQBkM0q8ZRZmO1zI6Bsv94A6pDMc506fsrFEXYTqtXw/joZC8qDt OifIHw6RU/yvDVCkIaluRZzPB9BQhYtqUXcOby2DMcBB8lxKnFse8uqSzwJvP73NJtke OtduOp213lYAbFs/AGBQ4Qp9baeYV23EobbzA3k3HU90pUfkgg4+F41NaNbbzY2pdAqv FEblitNBGNTHjwr/auq4Nu4KzMAgyYYxvIFfi6S+jSh8gI2RHYVs208SAR9TznJe89tD qLgw== X-Forwarded-Encrypted: i=1; AJvYcCUkjj50ppeIc6AemNdcjkZCEQhx3K8YemyTHB76EOy2YCweFKIMspDu6FWV7w5qQLz/8kg5330KoTE7AUg=@vger.kernel.org X-Gm-Message-State: AOJu0YzIF+Vda4F/U/7KLwMNZrE9ctjhKUZQxX9hgoRKG5EVBqvl/iju hyIUXpTNEx/osPMCtHqlWbnK54b/qaf2uwxxOnqieEAtFDiQpbwMuUhO X-Gm-Gg: ATEYQzx04uMzHQ+lWVlQk1kFvIzdWHOekJRDLgyGze/jLJGNHtXL6iPoZzeM7cc0KJR IYK/81H/Z9IA5YRZLIB8lKp0ASdwswOovr2fiwMFfiLeP3l1FiATOYeT55ayBTsrMPgYpjIwTte P98AInUACgtU5cadKOrDcKYMIcoJoWseRyEF0owy3aQax4MRDrFK6eKvBNL/yPMs1vbqJG+lK3j a4LH9K1gjmC+EO9wNRqnUbN1m5Pt3X6BE48X4tQQIrJ2Cey65hiotBS9wnznZlJ2tecsarEmYxU sksnMwBSxH5nJkZlqZysQlQIUolfnv6WtrCYc0gCtco9Gr1qAITGn3AIZde/JSFdwUKBaYl1qIX N8XqQvGvLd+f2GVA9J+NTpIXJ/2x/saoBm498M3vJLJHDuPtAhCt+bv/gTsEUFEErYCoxQ+rnIf kr5lot4U+zNE94H1XweeXHI3UrG0hMN1MgpRHK3bIOn0Dzz4Pj1yv/I7J2oteVHcvTMvZMzogyP gkSY+GoISr5T5Uxeblsm4Wp X-Received: by 2002:a05:690c:d91:b0:798:4fd:7211 with SMTP id 00721157ae682-79829028641mr65498377b3.45.1771818044901; Sun, 22 Feb 2026 19:40:44 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dbd5939sm27285237b3.15.2026.02.22.19.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:40:44 -0800 (PST) From: Ethan Tidmore To: Jonathan Cameron , Andy Shevchenko Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , Andy Shevchenko Subject: [PATCH v5 05/10] iio: light: gp2ap020a00f: Fix possible error swallow Date: Sun, 22 Feb 2026 21:40:15 -0600 Message-ID: <20260223034020.27625-6-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223034020.27625-1-ethantidmore06@gmail.com> References: <20260223034020.27625-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move error check into for loop in gp2ap020a00f_buffer_postenable() and gp2ap020a00f_buffer_predisable(), this fixes a possible error swallow. Suggested-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v5: - Split this patch from the patch number 4, to keep bug fix separate from style fix. drivers/iio/light/gp2ap020a00f.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c index 6b283b52698f..d2156e133b75 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -1339,7 +1339,7 @@ static const struct iio_info gp2ap020a00f_info = { static int gp2ap020a00f_buffer_postenable(struct iio_dev *indio_dev) { struct gp2ap020a00f_data *data = iio_priv(indio_dev); - int i, err = 0; + int i, err; guard(mutex)(&data->lock); @@ -1366,11 +1366,10 @@ static int gp2ap020a00f_buffer_postenable(struct iio_dev *indio_dev) GP2AP020A00F_CMD_TRIGGER_PROX_EN); break; } + if (err) + return err; } - if (err < 0) - return err; - data->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL); if (!data->buffer) return -ENOMEM; @@ -1381,7 +1380,7 @@ static int gp2ap020a00f_buffer_postenable(struct iio_dev *indio_dev) static int gp2ap020a00f_buffer_predisable(struct iio_dev *indio_dev) { struct gp2ap020a00f_data *data = iio_priv(indio_dev); - int i, err = 0; + int i, err; guard(mutex)(&data->lock); @@ -1400,11 +1399,10 @@ static int gp2ap020a00f_buffer_predisable(struct iio_dev *indio_dev) GP2AP020A00F_CMD_TRIGGER_PROX_DIS); break; } + if (err) + return err; } - if (err) - return err; - kfree(data->buffer); return 0; } -- 2.53.0