From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB64C343D8F for ; Mon, 23 Feb 2026 12:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771849975; cv=none; b=GCMjrPmlUzxCnsPKbNu2/1KNLxa6+w9oak5ArFh8iycTYIx+9uY98KO3U4K0VP8Rtygs8DzZ1ggAkmuWd4zJA5t+JRe3nDPXBkfQb0uHtBQD4WZuZimQIK8NPdN8nxNt3gw95tUmyl+HJxlb+vYC/pcbOc7+r39mrElWzYBvK/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771849975; c=relaxed/simple; bh=+Gb05PxvumN+Pl9XaeCIZFLytIRa9gHhOeCrXLllhEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rx0dR5mIxR5ho1FWyP19roJobWfdd2ptWImOHJmiBM9Bj2wvxRZJdHAIMtRZgCMQvhQ1TzlHyqnIrn7ry2JvzUJ/4erNwkBEuhLWpngGqOseFidtjkXbMv0QxXMWb/wsrmU7Prd6AjbBwfaXoTagjAoP6oHLHCrMtOYzlCaVpt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H/b2j5D9; arc=none smtp.client-ip=209.85.215.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H/b2j5D9" Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-c648bc907ebso2526623a12.3 for ; Mon, 23 Feb 2026 04:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771849973; x=1772454773; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yRjDZcOUW3p8fFG0+tNWgPy65ed/dP2/X89AKu5rG9U=; b=H/b2j5D9dvoBKapcveYPneT/C/8NQHnWTUDk/Rnac6wSqhVzkkSGNwRhdSfB/qj8Sv k24hT0ZpxW4GaXyVyok+AJflu7U4ANYV+X7hxQLHHBGwkgff5fxGLaJcQUC/TAYb3pMU 3O0iZCoop1mJ+cuK+ezHz7uUrVHDljmwwaxSolwvJ0RaD3oYYLHtk9hDYaWc4NK+YlWP TxoSD5vIDMPURPxPu5hK3TqgbfVSO5wNcdoeNy/rYds8JbaProv5IxBi57lRQzE4UQAa DNv21T6432HeMFAep9gEMrb3NquuHZNQppyscQByFKIHk1M0pB3t3/me13y+GeR2SUgy e7zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771849973; x=1772454773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yRjDZcOUW3p8fFG0+tNWgPy65ed/dP2/X89AKu5rG9U=; b=pbTJyEGVv/1gyg3/McdArw/Y5N5KOeduT2nOfFwQpbQiDf3gDvpmY2CrPT0QkdNtUT cLlyzvj0SP/Pz5HPiEIqmOPxAu2t1SbdRhRU4x9zDpKZZHdObitv9IcmPse1CtVnigKO 6eIjYGO/3ATKhXq2TMOFk7cP+krjOO4fRlnmD3QNX2xqv/fo+aopIo7J623edSdI28Lz vf91gWfCt3W911nsZddynPUr5YqfsuhQgkqd9NKaV79o19lu1mxB5kEIeqabWgsOhNLk zT/nDixuq/DMaBzzcjoVnOl9II26zS5aT3TRC/J4EElmrndxTRnaouCJgvLRAOhc7Mte rQDw== X-Forwarded-Encrypted: i=1; AJvYcCU2mHZn41/PGQIqRvCYFg88rPF4JGWuwENpNpfiuH3ybfLrljkd3DKO6D8BsNI6PblqLY5LhyVGFepXFw4=@vger.kernel.org X-Gm-Message-State: AOJu0YwFO9sCyUVWhqbc4k/vVL+isYkWPHmovl4HQGX1d3bHohH8ONPl fztd+zE4ll/uvzwIvvEi2VL5ZF4Qr7tmbgYOh+XQC4ElaTWIyuX4m8I= X-Gm-Gg: AZuq6aKH9c2VvcY8o0YyBgmzYnqeNINbZ/wOfWkmPYfZek1vSCkS1Ai+3XsDsU5/UpI JP6Y/Gd11czSTdev+OhhO9DOyi4ZW8xqhwZZFxdQBrvDFJ21rKmVvSKmI5VvqR6pr8I7zCjmIGn /pDttM2wfKhxd4L2qw6DpOBvlDYZ3knVtVGVzos/v0jYAxMd+4i7scQJXyI9CU509490qSnPY9b 1EYdsD4FV6FF5BPsgVe13rx2yEaie03RAHisBRxmbOZwU43Vf55Kvx484WgyUa5fuvZbe+H1wmA X6g/7EoyAWJfkyNovOTfxr4HWxexYWnfJoi0UgQEvO9zFKG41NzzmgsifyHQpkkEmgra67k1Gyv ryfWP3HOHJd4SAzfKd9E7rIq1+linsQ1lNTot2RvXnHD8suJQ1QLGVMDXgyRj20A67yzMZ4+czL CS64U7S9Z7UA246fHH5BEPOpHTxu6BxVPTXiqD/S+8yamr X-Received: by 2002:a05:6a20:d80f:b0:395:291b:f555 with SMTP id adf61e73a8af0-395460224e4mr6425517637.69.1771849973278; Mon, 23 Feb 2026 04:32:53 -0800 (PST) Received: from LAPTOP-FDBL0TVI.localdomain ([49.37.157.71]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b71a73e1sm7454739a12.13.2026.02.23.04.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 04:32:52 -0800 (PST) From: Ravi Jonnalagadda To: sj@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, bijan311@gmail.com, ajayjoshi@micron.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Ravi Jonnalagadda Subject: [RFC PATCH v3 1/4] mm/damon/sysfs: set goal_tuner after scheme creation Date: Mon, 23 Feb 2026 12:32:29 +0000 Message-ID: <20260223123232.12851-2-ravis.opensrc@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223123232.12851-1-ravis.opensrc@gmail.com> References: <20260223123232.12851-1-ravis.opensrc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_new_scheme() always sets quota.goal_tuner to CONSIST (the default) regardless of what was passed in the quota struct. This caused the sysfs goal_tuner setting to be ignored. The comment in damon_new_scheme() says "quota.goals and .goal_tuner should be separately set by caller", but the sysfs code wasn't doing this. Add explicit assignment of goal_tuner after damon_new_scheme() returns to properly apply the user's setting. Without this fix, setting goal_tuner to "temporal" via sysfs has no effect - the scheme always uses the CONSIST (feed loop) tuner, causing overshoot when the goal is reached instead of immediate stop. Signed-off-by: Ravi Jonnalagadda --- mm/damon/sysfs-schemes.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index bbea908074bb..fe2e3b2db9e1 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2809,6 +2809,9 @@ static struct damos *damon_sysfs_mk_scheme( if (!scheme) return NULL; + /* Set goal_tuner after damon_new_scheme() as it defaults to CONSIST */ + scheme->quota.goal_tuner = sysfs_quotas->goal_tuner; + err = damos_sysfs_add_quota_score(sysfs_quotas->goals, &scheme->quota); if (err) { damon_destroy_scheme(scheme); -- 2.43.0