From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3D0366807; Mon, 23 Feb 2026 12:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771850287; cv=none; b=HfYtHkfB1RFbU6FTsrGjzND5fmd5b0XRaBT0oZRF+0iJoNYVnPCR5xjnvoEZIF5M90P3ANZdYi0Gj2IuYycERh0Ss9pWALoHZsppuN9pIC89uqDlCL4t4ELNtkfyW6Gr1bTveREOnk5/g8poAt5zXvBlQOMwpbBou9J5E0SLPT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771850287; c=relaxed/simple; bh=GH64Xio/xNmrTz43HQgczXVCE9RAw80ZZ/U8bMFFlzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rhGjzE9D58ow/IhPCJO2Ogug8gWmviGmGDiUg0NxwETyB1sToJe5Zr1UWom1R+6u7e9zRt2G/hqqbyThGmhGUYKWjLyrJHsl8UeMrmRZ1LQM9WXQy7VFeP65zxXiLS0foX6TQSLk2A7iOFXOJWzmp9GDTYKMLFq6lzwwfApbv1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KG2yg52P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KG2yg52P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60BD6C2BC87; Mon, 23 Feb 2026 12:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771850287; bh=GH64Xio/xNmrTz43HQgczXVCE9RAw80ZZ/U8bMFFlzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KG2yg52Pn+QsxFuklWzElpRdJ5rgkpqI9zYzIL6Rh77F1F7iDuCTPFnif07BAOofT nhZ0Px7cTt4shFVCEWva5PfwlKJ2sB9VhMUtc5B3Yc3dj18cY8Rz6KwzCnrLUI5fVW egO1uzXUHGKYA0G/vim1XWnZhMl67JzYdY6fARYEvx37BwAUIp6CNRGparsk0b4EuM 9YJ0YaKEWr3H6UGpLs3Mg74PazL4F9fhtw1Hh0+DT4lhSJCrosIPwOxB/n1/Fzlx3y PEKoVN7q4k+0Tone08xyaIXVtVwE0G4V8KOpar7umunCMfDPWMv2mCRX1/QraK8jfp TWxjAJ0Ke1EbQ== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Aaron Erhardt , Werner Sembach , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.19-6.18] ALSA: hda/hdmi: Add quirk for TUXEDO IBS14G6 Date: Mon, 23 Feb 2026 07:37:24 -0500 Message-ID: <20260223123738.1532940-19-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260223123738.1532940-1-sashal@kernel.org> References: <20260223123738.1532940-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.19.3 Content-Transfer-Encoding: 8bit From: Aaron Erhardt [ Upstream commit d649c58bcad8fb9b749e3837136a201632fa109d ] Depending on the timing during boot, the BIOS might report wrong pin capabilities, which can lead to HDMI audio being disabled. Therefore, force HDMI audio connection on TUXEDO InfinityBook S 14 Gen6. Signed-off-by: Aaron Erhardt Signed-off-by: Werner Sembach Link: https://patch.msgid.link/20260218213234.429686-1-wse@tuxedocomputers.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: ## Analysis ### Commit Summary This commit adds a single `SND_PCI_QUIRK` entry to the `force_connect_list[]` table in the HDA HDMI audio codec driver for the TUXEDO InfinityBook S 14 Gen6 laptop (PCI subsystem ID `0x1558:0x14a1`). ### Problem Being Fixed The commit message explains that depending on boot timing, the BIOS may report incorrect pin capabilities, which can result in HDMI audio being completely disabled. The quirk forces the HDMI audio connection to work around this firmware bug. ### Code Change Analysis The change is a single line addition: ```c SND_PCI_QUIRK(0x1558, 0x14a1, "TUXEDO InfinityBook S 14 Gen6", 1), ``` This is added to the existing `force_connect_list[]` table, which is already populated with many similar entries for HP, ASUS, MSI, and Intel devices. The quirk value `1` forces the HDMI connection, matching the pattern of all other entries in the list. ### Stable Kernel Rules Assessment 1. **Obviously correct and tested**: Yes - it's a trivial one-line addition to an existing quirk table, following the exact same pattern as ~20 other entries. The authors are from TUXEDO Computers (the hardware vendor), so they tested on the actual hardware. 2. **Fixes a real bug**: Yes - HDMI audio can be non-functional on this laptop due to a BIOS timing issue. This is a real user-facing bug. 3. **Important issue**: Yes - complete loss of HDMI audio output is a significant functional issue for users of this laptop. 4. **Small and contained**: Yes - it's a single line in a single file, adding an entry to an existing table. 5. **No new features**: Correct - this is a hardware quirk/workaround for a broken BIOS, not a new feature. 6. **Applies cleanly**: The change is a simple table entry addition that should apply cleanly to any stable tree that has the `force_connect_list[]` table. ### Exception Category This falls squarely into the **QUIRKS and WORKAROUNDS** exception category. Hardware-specific quirks for broken/buggy devices (in this case, a BIOS firmware bug) are explicitly listed as appropriate for stable backporting. Audio codec quirks via `SND_PCI_QUIRK` entries are specifically called out in the stable kernel guidelines. ### Risk Assessment - **Risk**: Essentially zero. The quirk only activates for the specific PCI subsystem ID `0x1558:0x14a1`. It cannot affect any other hardware. - **Benefit**: Fixes HDMI audio for all users of the TUXEDO InfinityBook S 14 Gen6. ### Verification - Verified the diff: Single-line addition of `SND_PCI_QUIRK(0x1558, 0x14a1, "TUXEDO InfinityBook S 14 Gen6", 1)` to the existing `force_connect_list[]` table. - Verified the table structure: All other entries in the table follow the identical `SND_PCI_QUIRK(vendor, device, name, 1)` pattern, confirming this entry is consistent. - Verified authors: `@tuxedocomputers.com` email domains confirm the authors are from the hardware vendor, meaning they have direct access to and have tested on the affected hardware. - Verified the maintainer ack: Signed-off-by from Takashi Iwai (ALSA/HDA maintainer at SUSE), confirming proper review. - Verified no dependencies: This is a standalone table entry addition with no prerequisite commits needed. - The `force_connect_list[]` table has existed for multiple stable kernel versions (verified by the presence of many existing entries in the code). ### Conclusion This is a textbook stable backport candidate. It's a single-line hardware quirk addition that fixes a real bug (HDMI audio disabled) on specific hardware, with zero risk to other systems. It follows the exact same pattern as dozens of similar quirk entries already in the table. **YES** sound/hda/codecs/hdmi/hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/codecs/hdmi/hdmi.c b/sound/hda/codecs/hdmi/hdmi.c index 111c9b5335afc..c2e3adc7b3c00 100644 --- a/sound/hda/codecs/hdmi/hdmi.c +++ b/sound/hda/codecs/hdmi/hdmi.c @@ -1557,6 +1557,7 @@ static const struct snd_pci_quirk force_connect_list[] = { SND_PCI_QUIRK(0x1043, 0x86ae, "ASUS", 1), /* Z170 PRO */ SND_PCI_QUIRK(0x1043, 0x86c7, "ASUS", 1), /* Z170M PLUS */ SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1), + SND_PCI_QUIRK(0x1558, 0x14a1, "TUXEDO InfinityBook S 14 Gen6", 1), SND_PCI_QUIRK(0x8086, 0x2060, "Intel NUC5CPYB", 1), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1), {} -- 2.51.0