From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B4F883F
	for <linux-kernel@vger.kernel.org>; Mon, 23 Feb 2026 13:24:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771853071; cv=none; b=SuDRtF9qSOr4E08nmHHDq1rpMKAx1b2DDaxR8KTlwAbVRIBsOBy9uX1uxlC6csRNzdVTi7jWX4Cjmt8gra5CIsXXQjs90Aahb0i6Ug/VcRMM0aD27ITLAz/jbcqQTDtkMxImFCmGYeN6pfUdDRF8xjNH9ngAOfZz6lK1RUvojE8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771853071; c=relaxed/simple;
	bh=mc/kZy5mim7j+mf0FLe15WqkQ9otUZX61D7WJlyoweM=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=GUX/JF9N7cRyqVvXUfPD/URKIYI8M/uB0lJpGFsfN6JBzzmRNFn/DVZjRDGgfTgv2QWa9fyywrxFxMqO0T+QXHp5+485GQDJw2q3aTq2MetAjAV0etB1LfSTt95qr5XZTs0fEn52Ga7eBJWkDLGGDpIGQu9yJrkv5wNffaacgZY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id DABBE68AFE; Mon, 23 Feb 2026 14:24:20 +0100 (CET)
Date: Mon, 23 Feb 2026 14:24:20 +0100
From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] nvme: add preferred I/O size fields to struct
 nvme_id_ns_nvm
Message-ID: <20260223132420.GA14767@lst.de>
References: <20260220032809.758089-1-csander@purestorage.com> <20260220032809.758089-2-csander@purestorage.com> <20260220160639.GB15071@lst.de> <CADUfDZq5xVsWyJuwi2=aWMqjqQDMzScp+sYXkp7YEq-pKz4EtA@mail.gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADUfDZq5xVsWyJuwi2=aWMqjqQDMzScp+sYXkp7YEq-pKz4EtA@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Fri, Feb 20, 2026 at 06:55:25PM -0800, Caleb Sander Mateos wrote:
> Looks like static_assert() was added 3 years before struct nvme_id_ns_nvm :)
> Definitely agree it's good to assert on these struct sizes.
> 
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Assuming you meant "Reviewed-by". Let me know if you meant something else.

Yes, sorry.