From: Christoph Hellwig <hch@lst.de>
To: Sungwoo Kim <iam@sung-woo.kim>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Chao Shi <cshi008@fiu.edu>, Weidong Zhu <weizhu@fiu.edu>,
Dave Tian <daveti@purdue.edu>,
Mike Christie <michael.christie@oracle.com>
Subject: Re: [PATCH] nvme: fix memory allocator in nvme_pr_read_keys()
Date: Mon, 23 Feb 2026 14:41:04 +0100 [thread overview]
Message-ID: <20260223134104.GA15458@lst.de> (raw)
In-Reply-To: <20260216003541.161806-2-iam@sung-woo.kim>
s/allocator/allocation/ in the subject.
> - rse = kzalloc(rse_len, GFP_KERNEL);
> + rse = kvzalloc(rse_len, GFP_KERNEL);
You'll also need it to free it using kvfree if you you use kvzalloc.
We might also want to add some upper bound to the number of keys
to not allow the user to allocate 4GB of pinned kernel memory.
next prev parent reply other threads:[~2026-02-23 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 0:35 [PATCH] nvme: fix memory allocator in nvme_pr_read_keys() Sungwoo Kim
2026-02-22 20:42 ` Sungwoo Kim
2026-02-23 13:41 ` Christoph Hellwig [this message]
2026-02-23 16:00 ` Sungwoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223134104.GA15458@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cshi008@fiu.edu \
--cc=daveti@purdue.edu \
--cc=iam@sung-woo.kim \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michael.christie@oracle.com \
--cc=sagi@grimberg.me \
--cc=weizhu@fiu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox