Re: [net-next, v2 2/2] selftests: drv-net: psp: add test for VLAN sub-interface

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 23 Feb 2026 11:11:54 -0800 Kiran Kella wrote:
> Add test to validate that the psp device information is propagated
> properly from the lower device to the upper devices so that
> the PSP transmit validation passes.
> 
> Signed-off-by: Kiran Kella <kiran.kella@broadcom.com>
> Reviewed-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Looks like you need to enable VLAN in the respective config file in
ksft:

# ok 28 psp.removal_device_bi
# # Exception| Traceback (most recent call last):
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/net/lib/py/ksft.py", line 338, in ksft_run
# # Exception|     func(*args)
# # Exception|     ~~~~^^^^^^^
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/drivers/net/./psp.py", line 597, in vlan_basic_send
# # Exception|     ip(f"link add link {cfg.ifname} name {local_vlan_ifname} type vlan id {vlan_id}")
# # Exception|     ~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/net/lib/py/utils.py", line 238, in ip
# # Exception|     return tool('ip', args, json=json, host=host)
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/net/lib/py/utils.py", line 225, in tool
# # Exception|     cmd_obj = cmd(cmd_str, ns=ns, host=host)
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/net/lib/py/utils.py", line 91, in __init__
# # Exception|     self.process(terminate=False, fail=fail, timeout=timeout)
# # Exception|     ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# # Exception|   File "/srv/vmksft/testing/wt-17/tools/testing/selftests/net/lib/py/utils.py", line 117, in process
# # Exception|     raise CmdExitFailure("Command failed", self)
# # Exception| net.lib.py.utils.CmdExitFailure: Command failed
# # Exception| CMD: ip link add link eni1972np1 name eni1972np1.100 type vlan id 100
# # Exception|   EXIT: 2
# # Exception|   STDERR: Error: Unknown device type.
-- 
pw-bot: cr