Re: [PATCH 1/2] dt-bindings: input: add adi,max16150.yaml

[Rob Herring <robh@kernel.org>]

On Mon, Feb 23, 2026 at 07:03:39PM +0800, Marc Paolo Sosa wrote:
> Add documentation for device tree bindings for MAX16150/MAX16169
> 
> Signed-off-by: Marc Paolo Sosa <marcpaolo.sosa@analog.com>
> ---
>  .../devicetree/bindings/input/adi,max16150.yaml    | 57 ++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/adi,max16150.yaml b/Documentation/devicetree/bindings/input/adi,max16150.yaml
> new file mode 100644
> index 000000000000..327811e1ebd4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/adi,max16150.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/adi,max16150.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX16150/MAX16169 nanoPower Pushbutton On/Off Controller
> +
> +maintainers:
> +  - Marc Paolo Sosa <marcpaolo.sosa@analog.com>
> +
> +description:
> +  The MAX16150/MAX16169 is a low-power pushbutton on/off controller with a
> +  switch debouncer and built-in latch. It accepts a noisy input from a
> +  mechanical switch and produces a clean latched output, as well as a one-shot
> +  interrupt output.
> +
> +properties:
> +  compatible:
> +    description:
> +      Specifies the supported device variants. The MAX16150 and MAX16169 are supported.

Drop description.

> +    enum:
> +      - adi,max16150a
> +      - adi,max16150b
> +      - adi,max16169a
> +      - adi,max16169b

What's the diff between a and b? If nothing s/w needs to know about, 
then maybe you don't need to distinguish. 

> +
> +  interrupt-gpio:
> +    maxItems: 1

Use 'interrupts' property.

> +
> +  clr-gpios:
> +    description:
> +      Clear Input. Pulling CLR low deasserts the latched OUT signal. If OUT is
> +      already deasserted when CLR is pulled low, the state of OUT is unchanged.
> +    maxItems: 1
> +
> +  linux,code:
> +    default: KEY_POWER
> +
> +required:
> +  - compatible
> +  - interrupt-gpios
> +  - clr-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/input/linux-event-codes.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    power-button {
> +        compatible = "adi,max16150a";
> +        interrupt-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
> +        clr-gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
> +        linux,code = <KEY_POWER>;
> +    };
> 
> -- 
> 2.34.1
>