From: Artem Lytkin <iprintercanon@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Artem Lytkin <iprintercanon@gmail.com>
Subject: [PATCH v2 3/3] staging: most: dim2: remove unnecessary string indirection in dev_err
Date: Mon, 23 Feb 2026 21:09:50 +0000 [thread overview]
Message-ID: <20260223210950.1900-4-iprintercanon@gmail.com> (raw)
In-Reply-To: <20260223210950.1900-1-iprintercanon@gmail.com>
Replace dev_err(&pdev->dev, "%s\n", "clk_prepare_enable failed") with
the direct format string dev_err(&pdev->dev, "clk_prepare_enable
failed\n"). The extra level of indirection through %s is unnecessary.
Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
---
drivers/staging/most/dim2/dim2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index e4c8b4995c61..66617e89e028 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -927,7 +927,7 @@ static int fsl_mx6_enable(struct platform_device *pdev)
ret = clk_prepare_enable(dev->clk);
if (ret) {
- dev_err(&pdev->dev, "%s\n", "clk_prepare_enable failed");
+ dev_err(&pdev->dev, "clk_prepare_enable failed\n");
return ret;
}
@@ -975,7 +975,7 @@ static int rcar_gen2_enable(struct platform_device *pdev)
ret = clk_prepare_enable(dev->clk);
if (ret) {
- dev_err(&pdev->dev, "%s\n", "clk_prepare_enable failed");
+ dev_err(&pdev->dev, "clk_prepare_enable failed\n");
return ret;
}
@@ -1020,7 +1020,7 @@ static int rcar_gen3_enable(struct platform_device *pdev)
ret = clk_prepare_enable(dev->clk);
if (ret) {
- dev_err(&pdev->dev, "%s\n", "clk_prepare_enable failed");
+ dev_err(&pdev->dev, "clk_prepare_enable failed\n");
return ret;
}
--
2.43.0
next prev parent reply other threads:[~2026-02-23 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 20:19 [PATCH 0/2] staging: most: dim2: fix error handling in fsl_mx6_enable Artem Lytkin
2026-02-16 20:19 ` [PATCH 1/2] staging: most: dim2: check return value of clk_prepare_enable for PLL Artem Lytkin
2026-02-16 20:19 ` [PATCH 2/2] staging: most: dim2: fix error handling in fsl_mx6_enable Artem Lytkin
2026-02-19 8:18 ` Dan Carpenter
2026-02-23 21:09 ` [PATCH v2 0/3] staging: most: dim2: clean up " Artem Lytkin
2026-02-23 21:09 ` [PATCH v2 1/3] staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_get Artem Lytkin
2026-02-23 21:09 ` [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Artem Lytkin
2026-02-23 21:09 ` Artem Lytkin [this message]
2026-02-24 4:37 ` [PATCH v2 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 1/3] staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_get Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 3/3] staging: most: dim2: remove unnecessary string indirection in dev_err Artem Lytkin
2026-02-24 17:55 ` [PATCH v2 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223210950.1900-4-iprintercanon@gmail.com \
--to=iprintercanon@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox