From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F873793C7 for ; Mon, 23 Feb 2026 21:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883837; cv=none; b=uic03q33M2vmka4sxcxIQCdGXjoNm93pEZCD4tgX8nGAX/IEBw6Sfxy6FT73Y6ek/rQAimeVoGK24pf5IzmG4YT0mpEA69xb4/Uw92WFk+2+Z7cCcFMnkaoCvmeuDM7FPuTry4a0QsGXmvb7zETxAm1KaRVt1QtlG5YU44bk2eE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883837; c=relaxed/simple; bh=E92lXIRr60SHMg2fArc47BQNbTfjxQG/SOtt2nLRB3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X4ixJKPbiSwZlfPHPdYVWH1mZbQYE0sR1jMf4SmTU84kuGtFHCcrDd7C1lCShe4Akwjt2tK7qUJiNYcCgiqnfnRyF2NK4MdpRFnXU0pAXP12i1yW4BnG6HZjMEzDbMeuX4zKvCQin0UupkTKN2KNRqPVZaIicJEmtzjdgYEsag4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7iBs5jA; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7iBs5jA" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3530715386cso4018193a91.2 for ; Mon, 23 Feb 2026 13:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883835; x=1772488635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lQTr7mgIilChf/JeESIDYXvGnp4mBQvya6Be0H5NIwM=; b=Q7iBs5jA4ZkGHyjPCDWIne4dRD4AbPC8Bk2OU9oDin1l7AW9zpXyNJ/lCncbPWN/1n QE5TL455craZ1baYHR8sZ/0MoolX0tthbzMu8Gx6PBtaa5FW+0yHcNST+JwDEhtw/7Bv dcSf1cEvVeLEmXo9YolRpKggsHmyBp8XCLWRBbrKOXmYyxSXnvKJY6DjPioFm4BXnqlQ ZLjtkbgqMecxnW3kzC3PqyKB/njcHQCnlzfufgLZ7pcFvhiwJtEEemnzA5k3dOpgZ/aA 8++x8Rixh9bucORypwujWkqRI0HcP1NqEhQ59gKN3pdcQYfI9V3OGiTYF4GYBzdcivKi vikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883835; x=1772488635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lQTr7mgIilChf/JeESIDYXvGnp4mBQvya6Be0H5NIwM=; b=bcEtmilu0GFBktWJVPALJSAi9ACa5nKRpOtr7ujbCiLpg8dfRYn2eY7cd2mGyg98Ow wOzRwy+SKeu/kwU74Hd2AR/fyRBAIgHX6QUxOkMOJaTuy5CImo+CqDSMbRKdjfyytSLH 8nnIqju16yfHqB9FSbcfSdW1cK7q0D74hRLvVWvbxIEuljfSgfrUoQ+K5iUUZEXwAnFW VxKFbH1jWT6fnlrYKtL1cOiFf+roUk3o7AAgpSTCqFh/Ged6CkUW+kA76ikd8ciEnmUv HYHskod9gI/vgzY5jhqkQK+afQeNj46C8K9RaTDnOCAmRpRa9bJKm9l4/9Pc/U+LsdEV GiQQ== X-Forwarded-Encrypted: i=1; AJvYcCVtS56eWSTWzXvtYkmDTLxUMIl/Cqkb4LCMKa9TS2/o9decSaTOphGWT4klizULfK43hOAaByRRic1xMBY=@vger.kernel.org X-Gm-Message-State: AOJu0YzihNj4iDNjXgTYdaJOz1uD4O7EHH5zI1+uPv/KK3/IPCoX17Bi kJadN6wuMhJd667kbnWIr6ozHTsA/mdZ/JOuxKo82+r0IzrjV0cdhZ1q X-Gm-Gg: ATEYQzw7fv8g7wd4GswxvZN9/WhGEFVTxpjPrYeqV6aSYouoiOIR2HrbfIuqeOqdAAa Cbyxpx+cPs988/I/aBHNNgL/625fUrcA0v7sPhBM3iupvFp3595tHuUx56IZCpKH5gj6ZJqiOE2 R6vzI+SfpQGTYDCfgnSyvbDEoOp4kzYgKkiAToUNrnasdO6Ez7cKkk4v84BQrCzKUCRdQNdKdWc KtoKts+qO7xdyDKrej5E/BdlV7TVrOdDQiMxI7ifBc6ShSt4n8bRlHHoSzT8oLN8QNB0d5li89/ 13PgXj+4tFY91DaHlxr6oTY3l295z+MaF2+LapHY526xFFd/BK5Nj7UJgJ4/UYA4BkzAhB0w3Ml SJxx4hkQcrF1NN472jXY68yVD28AePGNWA8A+o82/+HUwG3zdWACkiUc/n/I/2/h7R08/ITJVft NSh5Bn3wXHckxnJh3soJQhIw== X-Received: by 2002:a17:90b:5410:b0:340:ca7d:936a with SMTP id 98e67ed59e1d1-358ae8a87e3mr9532992a91.18.1771883835258; Mon, 23 Feb 2026 13:57:15 -0800 (PST) Received: from arch ([2409:40c2:5428:afe:6feb:bc4:5ef7:1700]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358dc0092d1sm352772a91.5.2026.02.23.13.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:57:15 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v4 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Date: Tue, 24 Feb 2026 03:26:34 +0530 Message-ID: <20260223215636.18606-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223215636.18606-1-rougueprince47@gmail.com> References: <20260223215636.18606-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: WARNING: Argument '(x)' is not used in function-like macro Signed-off-by: Bhargav Joshi --- drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) -- 2.53.0