From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C07C37BE7D for ; Mon, 23 Feb 2026 22:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884123; cv=none; b=Ch43QjmsDC/fT4LAgxoUWskxLxOnVM1YJxx2epfMHQqUDY/siCPO+QIowt0AynkvKo3cV41PWdwnSRw1pYU3mX2mpRduwTYTRGkgJCZPORo1RWy8eonNepPOiGBKTSFw6tMFrXMg9oxgioR/stuf4UAn/qB5qegO2Z1ljbniR6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884123; c=relaxed/simple; bh=3XRjx97f9GHu2z/tOYjVThB9danwe+rBsa1fxKFv79g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GzJrF3w1O1u32CTpeNEvwDE1SyYiOjSM2/o4tHNu1SECqMDESvG40Z+tFfdZoEzbVTAxxnqd3hb2lhHJfnlPFlInevfvPpEpNZX6m9IpVCEwTVSCLmREZfxKbBrlJE679FuRithFbev491G1CPBA2CQgTFOiII4kpXbPJ0AIxr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NsEp2gyG; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NsEp2gyG" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3hbG87+8LyuupCuzKSJcjWeumZ8W0iihnl6iS7nMems=; b=NsEp2gyG0QkGfutwYBGOl/IBHFkhjwVZGTk67PHBRqhnAYc8TQkMzfdOvPDKqFXevpDp4o Q1vI0iVTXyeqrvwjXg5azWY8/hF6OA/x6wmxVTyhZVa26CQQBhHePxLlN4L8VawBcsOYV4 RQ9jagjOdagNIcqL7lBQ6QspMrgYOgw= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost , Himal Prasad Ghimiray , Maarten Lankhorst Subject: [PATCH 12/62] drm/gpusvm.c: Fix a locking bug in an error path Date: Mon, 23 Feb 2026 14:00:12 -0800 Message-ID: <20260223220102.2158611-13-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Only call drm_gpusvm_notifier_unlock() if drm_gpusvm_notifier_lock() was called first. This has been detected by the Clang thread-safety analyzer. Compile-tested only. Cc: Thomas Hellström Cc: Matthew Brost Cc: Himal Prasad Ghimiray Cc: Maarten Lankhorst Fixes: f1d08a586482 ("drm/gpusvm: Introduce a function to scan the current migration state") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/drm_gpusvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c index 24180bfdf5a2..e9b79ab2f83c 100644 --- a/drivers/gpu/drm/drm_gpusvm.c +++ b/drivers/gpu/drm/drm_gpusvm.c @@ -819,7 +819,7 @@ enum drm_gpusvm_scan_result drm_gpusvm_scan_mm(struct drm_gpusvm_range *range, if (!(pfns[i] & HMM_PFN_VALID)) { state = DRM_GPUSVM_SCAN_UNPOPULATED; - goto err_free; + goto unlock; } page = hmm_pfn_to_page(pfns[i]); @@ -856,9 +856,10 @@ enum drm_gpusvm_scan_result drm_gpusvm_scan_mm(struct drm_gpusvm_range *range, i += 1ul << drm_gpusvm_hmm_pfn_to_order(pfns[i], i, npages); } -err_free: +unlock: drm_gpusvm_notifier_unlock(range->gpusvm); +err_free: kvfree(pfns); return state; }