From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A65537998C for ; Mon, 23 Feb 2026 22:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884167; cv=none; b=jIyh/X/Sa/lRaedDtxm4bin4iAKG2QsD+xpCBIp7mtte34aBCt4WQeqb666+wIm9tIjPG29l0LhIh2XWFQMk9wVkJVIJw8YIrkDSDQg0CY9lw9H7Ik9lFmyssBSd3QhrnqI+qiKN9XgIZvdqLeYvMPq3l3ea2qjEWrky0+1sWfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884167; c=relaxed/simple; bh=92d+FOudvrddyxkwql9KxUWV0hCmDy7gNGeatzFdS/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SCbaocMU5nRc55+hPpcKrWiqYCBcqVdLub9MfGM2JqK2hdIR6tx0R3nxoivl/xe8tUAQI8sVCsZUqO/QfsuqZzcH4R8YeLQJAtw0c09IirqkPaD0muN5nGhv8JLjSoPDwhlOuXV2gV1fYAgntNPChcJZVXi2lUx/SZp5UFqK+p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hHwoUBnM; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hHwoUBnM" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6lP5X6VaaBiaAV+H2+8twFzXZhF3w92H0A40Cwd0W1o=; b=hHwoUBnMU7hdnMXA+/igub6kiCjMOulEoO922VjxIxx0hdhh2y6v5OGVe4J4OWfj0n6PMq Dg8xcvsHqo2xW3Uq/7UI5Ni4vP7q3yTqsUvn+5WCccxfOXUajoA9vRPkmL8JpCOhulqDzG K2h3GqB+AtMFja2iLNxS+A7JoKkL1+E= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Daniel Golle , Andrew Lunn , Jakub Kicinski , Xu Liang , netdev@vger.kernel.org Subject: [PATCH 23/62] net: phy: mxl-86110: Fix locking in an error path Date: Mon, 23 Feb 2026 14:00:23 -0800 Message-ID: <20260223220102.2158611-24-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Only call phy_unlock_mdio_bus() if phy_lock_mdio_bus() has been called first. This has been detected by the Clang thread-safety analyzer. Cc: Daniel Golle Cc: Andrew Lunn Cc: Jakub Kicinski Cc: Xu Liang Cc: netdev@vger.kernel.org Fixes: 3d1b3f4ffc0a ("net: phy: mxl-86110: add basic support for MxL86111 PHY") Signed-off-by: Bart Van Assche --- drivers/net/phy/mxl-86110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mxl-86110.c b/drivers/net/phy/mxl-86110.c index 42a5fe3f115f..d010b023f7b9 100644 --- a/drivers/net/phy/mxl-86110.c +++ b/drivers/net/phy/mxl-86110.c @@ -891,7 +891,7 @@ static int mxl86111_config_inband(struct phy_device *phydev, unsigned int modes) MII_BMCR, BMCR_ANENABLE, (modes == LINK_INBAND_DISABLE) ? 0 : BMCR_ANENABLE); if (ret < 0) - goto out; + return ret; phy_lock_mdio_bus(phydev);