From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C58E837AA7A for ; Mon, 23 Feb 2026 22:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884179; cv=none; b=Lg8DJQDMGkE8+nBRvaqVJO3cD5jvU4DwXEkzBH5dnhlg61q2qoHW/c0N5ALp36Y3WLTE/TeCPuoCbmtVQgFM84pp1ZuFbhyzSDkULv8jCJEmeeGPw3U7OCyaKsu80Icd1C8iinFgHCG19xRX0Ps0+JpC0aZjfn/ozH6NJ+/jp5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884179; c=relaxed/simple; bh=4VFa7LNgk2a1HcOTugYMZUQVjyqdSB8n+ha4SzC1vuA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qGAFPVYRrYNgdufG/YKhs8hZeG3eq4e/LpDQCgYQkJE7KsdrY882Y11w2ME9nA/YvIyrtom5R4asylZsRLrWqfeGWWmJG5ts0P6mR0Tl+iDdt4VzfHvVBZIFy1HtX0pPKz0kWGIDemRo7N3yVlX0dYXmYxjqR9YKWq4iF46wNGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=S02r07+W; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="S02r07+W" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QHBEiy2SVFSaGEYXqZwL1uhN8tj8NhrzQ+rhsctOPFQ=; b=S02r07+WoGWrCKZe+zPFkipYWy+dP/YsMmczR6ooIgXRVkmUnu/nHvkGOmTvB9cqqZ/M1e sotiHfMBfAwAYKLZHQimGml5/88qn1OJip4txr7lTULlDSfq9vXsG5O4w/sVk/ydNC/xLs kjl32U80nPRI6HKIjVoIwIjgoK/HgCk= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Krzysztof Kozlowski , "Michael S. Tsirkin" , Alexander Graf , The AWS Nitro Enclaves Team Subject: [PATCH 26/62] misc: nsm: Fix a locking bug in an error path Date: Mon, 23 Feb 2026 14:00:26 -0800 Message-ID: <20260223220102.2158611-27-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Bart Van Assche If nsm->lock has not been locked, do not unlock it from any error path. This bug has been detected by the Clang thread-safety analyzer. Cc: Krzysztof Kozlowski Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: The AWS Nitro Enclaves Team Cc: linux-kernel@vger.kernel.org Fixes: b9873755a6c8 ("misc: Add Nitro Secure Module driver") Signed-off-by: Bart Van Assche --- drivers/misc/nsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/nsm.c b/drivers/misc/nsm.c index ef7b32742340..185900cdad4a 100644 --- a/drivers/misc/nsm.c +++ b/drivers/misc/nsm.c @@ -367,7 +367,7 @@ static long nsm_dev_ioctl(struct file *file, unsigned int cmd, /* Copy user argument struct to kernel argument struct */ r = -EFAULT; if (copy_from_user(&raw, argp, _IOC_SIZE(cmd))) - goto out; + return r; mutex_lock(&nsm->lock);