From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BD037AA7A for ; Mon, 23 Feb 2026 22:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884182; cv=none; b=m58qRXqXNyufxLlgy3n5Z7ePs7FtB511i7Pp/9AaOnJ/VPUf/sy6ZEDJK9/4j275lUw2d87ftkAsLkQN5gNQ83CU1kNlZWu3QTR/4H1dsKP+l+ylM8I8vQ3RvytcKRc0YWEUgwVYR6taZe13VYAcKX1878UfPYg8SR0QS6Jci8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884182; c=relaxed/simple; bh=9Sb/xkU3v8/9uduQw8INIPdXie4ch1cc63FC0eUwks4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mDRXzWu1Ytf3b040ZCKJJlmCFV3ZupgmLXgaGj+NzOklYEmnbpUgk9+l37xUWPRXA0zRuZdQIL63Wete90RM/3chEQWAMoK8Hgce4vZeQXbfZq3Vw5dkDh+PfKmVblT7Bx2sr/tIqkNxWpXzVM6H7vVUnKWJX/HW27q/+FFPPzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=b9B2tjuk; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="b9B2tjuk" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lvLU3/OFGdKoVwhBbJQJP18E6kos8ULMe5LmNRtSO6Q=; b=b9B2tjuklqH75ksP6xPP5SMFQDHmY2nf/rzwbHWSgnsbxGw9swK4lW3bz0xxKnu+dZu+CF +OX9hYMAKTymCLnwr9JXbusWVBuUiyCPhasc1YITx7YXv6Gi8pKgRry37ryKBGBv90gTrI DGRpiJfpzYSjPq9cLWo4c7UeoRyIczM= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Bjorn Helgaas , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org Subject: [PATCH 27/62] pci: Fix locking in pci_do_resource_release_and_resize() error paths Date: Mon, 23 Feb 2026 14:00:27 -0800 Message-ID: <20260223220102.2158611-28-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Make sure that down(&pci_bus_sem) has been called before up(&pci_bus_sem) is called. This has been detected by the Clang thread-safety analyzer. Compile-tested only. Cc: Bjorn Helgaas Cc: Ilpo Järvinen Cc: linux-pci@vger.kernel.org Fixes: 337b1b566db0 ("PCI: Fix restoring BARs on BAR resize rollback path") Signed-off-by: Bart Van Assche --- drivers/pci/setup-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 61f769aaa2f6..3bb8cd9a581e 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -2346,6 +2346,7 @@ int pci_do_resource_release_and_resize(struct pci_dev *pdev, int resno, int size if (ret) return ret; + down_read(&pci_bus_sem); pci_dev_for_each_resource(pdev, r, i) { if (i >= PCI_BRIDGE_RESOURCES) break; @@ -2367,7 +2368,6 @@ int pci_do_resource_release_and_resize(struct pci_dev *pdev, int resno, int size if (!bus->self) goto out; - down_read(&pci_bus_sem); ret = pbus_reassign_bridge_resources(bus, res, &saved); if (ret) goto restore;