From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBDD1379997 for ; Mon, 23 Feb 2026 22:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884086; cv=none; b=owlUi1Qi9Xx+vRfl8OfjsYIc4hAi6DJHGrRrVngn9gtTytmMGcJ3jF5CAjWw4W/+kjLgH7WR96VuCE33Yj1aq19k2E34ng13g1TUgEEq3nR9YocgnySlECQu62zSV2JLV7O6DLe2U6sa2NZB8BJjkJjDgpF69LDTBdU4jCad8j8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884086; c=relaxed/simple; bh=WGkLiS9MZjtBAnFErKv0K5iFWAdpUe4u2FP3kC8rqEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nmeI4paVBLoks24fM4R2b2P1Tbk1j4NFLgMrx4MeGPh75YXKu5QQFdhSvBcVRl5vMSWKaGdq2Czju0EZiU2abtV2G9ttOFhemyyiRC1mer9JItnfubw9EnhQnlhXgN42x4cP3bR3PLlV1+xV0fSQSfbxpPKwaCxP5/oJ3kLZ7Qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KuzZJ/tV; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KuzZJ/tV" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771884083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aw0Lla25rrpcrf3Xx5jXGVyFmiYi2w+ViLecCy5WA1A=; b=KuzZJ/tV8iOE3ONdDapivzGZr/6CnqXPWF+qd9J0bTyaz7Y1jpGXjLZLv3m3E3lpRuJ+uL jNKYz+R10YqKf1tRNa0EwtjBS/rP0kuZ4LaFe5ZjSYqBnN8lXVRa0A5hskD51Kyw2pF2JN R4pYCf4bf1Mjm1ccqyxMjf+i175pbkg= From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Andreas Gruenbacher , linux-block@vger.kernel.org Subject: [PATCH 03/62] drbd: Balance RCU calls in drbd_adm_dump_devices() Date: Mon, 23 Feb 2026 14:00:03 -0800 Message-ID: <20260223220102.2158611-4-bart.vanassche@linux.dev> In-Reply-To: <20260223220102.2158611-1-bart.vanassche@linux.dev> References: <20260223220102.2158611-1-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Bart Van Assche Make drbd_adm_dump_devices() call rcu_read_lock() before rcu_read_unlock() is called. This has been detected by the Clang thread-safety analyzer. Compile-tested only. Cc: Andreas Gruenbacher Cc: linux-block@vger.kernel.org Fixes: a55bbd375d18 ("drbd: Backport the "status" command") Signed-off-by: Bart Van Assche --- drivers/block/drbd/drbd_nl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index e201f0087a0f..728ecc431b38 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3378,8 +3378,10 @@ int drbd_adm_dump_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } cb->args[0] = (long)resource; } } @@ -3628,8 +3630,10 @@ int drbd_adm_dump_peer_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } } cb->args[0] = (long)resource; }