[PATCH] staging: rtl8723bs: cleanup rtw_io.c

[PATCH] staging: rtl8723bs: cleanup rtw_io.c

[Wojciech]

Replace tabs with a space in return statements and declarations.
Remove dead code and redundant vendor comments.
No functional changes.

Signed-off-by: Wojciech S. <wojciech.develop@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_io.c | 49 ++++---------------------
 1 file changed, 7 insertions(+), 42 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c
b/drivers/staging/rtl8723bs/core/rtw_io.c
index 965c3cfea103..4b36a39946f1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -1,35 +1,11 @@
 // SPDX-License-Identifier: GPL-2.0
-/******************************************************************************
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- ******************************************************************************/
-/*
- * The purpose of rtw_io.c
- *
- * a. provides the API
- *
- * b. provides the protocol engine
- *
- * c. provides the software interface between caller and the hardware interface
- *
- *
- * Compiler Flag Option:
- *
- * 1. CONFIG_SDIO_HCI:
- *  a. USE_SYNC_IRP:  Only sync operations are provided.
- *  b. USE_ASYNC_IRP:Both sync/async operations are provided.
- *
- *  jackson@realtek.com.tw
- */

 #include <drv_types.h>

 u8 rtw_read8(struct adapter *adapter, u32 addr)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr);

  _read8 = pintfhdl->io_ops._read8;
@@ -39,9 +15,8 @@ u8 rtw_read8(struct adapter *adapter, u32 addr)

 u16 rtw_read16(struct adapter *adapter, u32 addr)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr);

  _read16 = pintfhdl->io_ops._read16;
@@ -51,9 +26,8 @@ u16 rtw_read16(struct adapter *adapter, u32 addr)

 u32 rtw_read32(struct adapter *adapter, u32 addr)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr);

  _read32 = pintfhdl->io_ops._read32;
@@ -63,9 +37,8 @@ u32 rtw_read32(struct adapter *adapter, u32 addr)

 int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  int (*_write8)(struct intf_hdl *pintfhdl, u32 addr, u8 val);
  int ret;

@@ -77,9 +50,8 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val)
 }
 int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  int (*_write16)(struct intf_hdl *pintfhdl, u32 addr, u16 val);
  int ret;

@@ -90,9 +62,8 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val)
 }
 int rtw_write32(struct adapter *adapter, u32 addr, u32 val)
 {
- /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;
  int (*_write32)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
  int ret;

@@ -107,7 +78,7 @@ u32 rtw_write_port(struct adapter *adapter, u32
addr, u32 cnt, u8 *pmem)
 {
  u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
  struct io_priv *pio_priv = &adapter->iopriv;
- struct intf_hdl *pintfhdl = &pio_priv->intf;
+ struct intf_hdl *pintfhdl = &pio_priv->intf;

  _write_port = pintfhdl->io_ops._write_port;

@@ -131,11 +102,6 @@ int rtw_init_io_priv(struct adapter *padapter,
void (*set_intf_ops)(struct adapt
  return _SUCCESS;
 }

-/*
- * Increase and check if the continual_io_error of this @param
dvobjprive is larger than MAX_CONTINUAL_IO_ERR
- * @return true:
- * @return false:
- */
 int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj)
 {
  int error_count = atomic_inc_return(&dvobj->continual_io_error);
@@ -146,7 +112,6 @@ int rtw_inc_and_chk_continual_io_error(struct
dvobj_priv *dvobj)
  return false;
 }

-/* Set the continual_io_error of this @param dvobjprive to 0 */
 void rtw_reset_continual_io_error(struct dvobj_priv *dvobj)
 {
  atomic_set(&dvobj->continual_io_error, 0);
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: cleanup rtw_io.c

[Greg KH]

On Sat, Feb 21, 2026 at 02:56:13PM +0100, Wojciech wrote:
> Replace tabs with a space in return statements and declarations.
> Remove dead code and redundant vendor comments.
> No functional changes.
> 
> Signed-off-by: Wojciech S. <wojciech.develop@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_io.c | 49 ++++---------------------
>  1 file changed, 7 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c
> b/drivers/staging/rtl8723bs/core/rtw_io.c
> index 965c3cfea103..4b36a39946f1 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_io.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_io.c
> @@ -1,35 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/******************************************************************************
> - *
> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
> - *
> - ******************************************************************************/
> -/*
> - * The purpose of rtw_io.c
> - *
> - * a. provides the API
> - *
> - * b. provides the protocol engine
> - *
> - * c. provides the software interface between caller and the hardware interface
> - *
> - *
> - * Compiler Flag Option:
> - *
> - * 1. CONFIG_SDIO_HCI:
> - *  a. USE_SYNC_IRP:  Only sync operations are provided.
> - *  b. USE_ASYNC_IRP:Both sync/async operations are provided.
> - *
> - *  jackson@realtek.com.tw
> - */
> 
>  #include <drv_types.h>
> 
>  u8 rtw_read8(struct adapter *adapter, u32 addr)
>  {
> - /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
>   struct io_priv *pio_priv = &adapter->iopriv;
> - struct intf_hdl *pintfhdl = &pio_priv->intf;
> + struct intf_hdl *pintfhdl = &pio_priv->intf;
>   u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr);
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] staging: rtl8723bs: cleanup rtw_io.c

[Bera Yüzlü]

Hello

I tried to apply this patch to my local tree, bu it failed due to a
formatting issue.

error: git diff header lacks filename information when removing 1
leading pathname component (line 101)

It seems like the patch is line wrapped and diff --git header split into
two lines.

Thanks, Bera