The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Linus Walleij <linusw@kernel.org>, Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH v2 2/4] iio: gyro: mpu3050: Fix irq resource leak
Date: Mon, 23 Feb 2026 20:35:09 -0600	[thread overview]
Message-ID: <20260224023511.274038-3-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com>

The interrupt handler is setup but only a few lines down if
iio_trigger_register() fails the function returns without properly
releasing the handler:

        ret = request_threaded_irq(irq,
                                   mpu3050_irq_handler,
                                   mpu3050_irq_thread,
                                   irq_trig,
                                   mpu3050->trig->name,
                                   mpu3050->trig);

...

        ret = iio_trigger_register(mpu3050->trig);
        if (ret)
                return ret;

        indio_dev->trig = iio_trigger_get(mpu3050->trig);

        return 0;
}

Add cleanup goto to resolve resource leak.

Detected by Smatch:
drivers/iio/gyro/mpu3050-core.c:1128 mpu3050_trigger_probe() warn:
'irq' from request_threaded_irq() not released on lines: 1124.

Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
 drivers/iio/gyro/mpu3050-core.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index 06162d886b59..b6e05afbe512 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -1121,11 +1121,16 @@ static int mpu3050_trigger_probe(struct iio_dev *indio_dev, int irq)
 
 	ret = iio_trigger_register(mpu3050->trig);
 	if (ret)
-		return ret;
+		goto err_iio_trigger;
 
 	indio_dev->trig = iio_trigger_get(mpu3050->trig);
 
 	return 0;
+
+err_iio_trigger:
+	free_irq(mpu3050->irq, mpu3050->trig);
+
+	return ret;
 }
 
 int mpu3050_common_probe(struct device *dev,
-- 
2.53.0


  parent reply	other threads:[~2026-02-24  2:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  2:35 [PATCH v2 0/4] Multiple bug fixes Ethan Tidmore
2026-02-24  2:35 ` [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Ethan Tidmore
2026-02-24  9:55   ` Linus Walleij
2026-02-24 10:02   ` Andy Shevchenko
2026-02-24  2:35 ` Ethan Tidmore [this message]
2026-02-24  9:56   ` [PATCH v2 2/4] iio: gyro: mpu3050: Fix irq resource leak Linus Walleij
2026-02-24 10:03   ` Andy Shevchenko
2026-02-24  2:35 ` [PATCH v2 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Ethan Tidmore
2026-02-24  9:56   ` Linus Walleij
2026-02-24 10:05   ` Andy Shevchenko
2026-02-24  2:35 ` [PATCH v2 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Ethan Tidmore
2026-02-24  9:57   ` Linus Walleij
2026-02-24 10:06   ` Andy Shevchenko
2026-02-24  2:42 ` [PATCH v2 0/4] Multiple bug fixes Ethan Tidmore
2026-02-24 10:08 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224023511.274038-3-ethantidmore06@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox