From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55345371047; Tue, 24 Feb 2026 10:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771929983; cv=none; b=d0FHGimnbKl/cDJ5rxtM7hrzCjs1RBS0iNLFX23o64AEylJhsOl7T4z04vrxbTguyiROFVboZ8449F5PV12owbJEJKhAqllHvERdHmgXv5zw6vmxhBgDwle9PfVbgBFN4MUsTZOCc3NJzxgx+w5UEyeDMzw+wj9NQkRYqGyvjsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771929983; c=relaxed/simple; bh=HoP5fJAicR6teMJFt4DKkW+JkP5LbKRJWcf04vaykBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=awaKuXBvTLPSF3qnRANIacI/Prn8lagzyIKDg+Ui6RJQ8sOzd5Ypiraa+p7n5g7XnTXGMLjBn9BxXJGLle8tZqg0kMaNlSy1eL8O9lIBq9JXOUC+lX/G0Z/3OUMfd9aWkn8mPERcJ8ffyMTiGBjEfpPA3QqMU6uxC5G8XXyXlTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LOub5Huj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LOub5Huj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D193C116D0; Tue, 24 Feb 2026 10:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771929982; bh=HoP5fJAicR6teMJFt4DKkW+JkP5LbKRJWcf04vaykBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LOub5HujeTkXdANgJ55GUZ5CYwGpn2k6ytz5eG7oFwOuY7hbxHQRh5j4zzQU+/XG0 MDhfvnwuUX5ANryHzTdI3QRXTrmpXCOQyDFUnGyDcgBBvHwUTQ8SB//MuzKNs0Bo1r DX5s8CRkfujyb8ugANRopZsCZgoDtyHb1M2gxFPKy/7Cf7hK7/1D+JaqkfT8bGc4T/ 2eX9/kXpiY+bewCwWcrAOJMQFLePCShCHOOLMHpTiq71UARwAsEDrostlO/lQFamNr DhtzbsItntd6hU4j4uwpdNMkM3Wom9tQsD8TWWx6zICSrrL7HCRB4opAGVRSUMzVZC LI2Lvo6eSpIUw== Date: Tue, 24 Feb 2026 12:46:18 +0200 From: Leon Romanovsky To: Cheng Xu Cc: Jason Gunthorpe , Selvin Xavier , Kalesh AP , Potnuri Bharat Teja , Michael Margolin , Gal Pressman , Yossi Leybovich , Kai Shen , Chengchang Tang , Junxian Huang , Abhijit Gangurde , Allen Hubbe , Krzysztof Czurylo , Tatyana Nikolova , Long Li , Konstantin Taranov , Yishai Hadas , Michal Kalderon , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Christian Benvenuti , Nelson Escobar , Dennis Dalessandro , Bernard Metzler , Zhu Yanjun , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH rdma-next 26/50] RDMA/erdma: Separate user and kernel CQ creation paths Message-ID: <20260224104618.GJ10607@unreal> References: <20260213-refactor-umem-v1-0-f3be85847922@nvidia.com> <20260213-refactor-umem-v1-26-f3be85847922@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 24, 2026 at 10:20:39AM +0800, Cheng Xu wrote: > > > On 2/13/26 6:58 PM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Split CQ creation into distinct kernel and user flows. The hns driver, > > inherited from mlx4, uses a problematic pattern that shares and caches > > umem in hns_roce_db_map_user(). This design blocks the driver from > > supporting generic umem sources (VMA, dmabuf, memfd, and others). > > > > In addition, let's delete counter that counts CQ creation errors. There > > are multiple ways to debug kernel in modern kernel without need to rely > > on that debugfs counter. > > > > Signed-off-by: Leon Romanovsky > > --- > > drivers/infiniband/hw/hns/hns_roce_cq.c | 103 ++++++++++++++++++++------- > > drivers/infiniband/hw/hns/hns_roce_debugfs.c | 1 - > > drivers/infiniband/hw/hns/hns_roce_device.h | 3 +- > > drivers/infiniband/hw/hns/hns_roce_main.c | 1 + > > 4 files changed, 82 insertions(+), 26 deletions(-) > > > > Hi Leon, > > The driver name in this patch's title should be "RDMA/hns". Right, thanks