From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B08396D36 for ; Tue, 24 Feb 2026 12:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771937240; cv=none; b=u13910kOLJHnOxM9e9ZOV2oMugDh1E9juPVOjM7ea4CXVcse7x9M0ek1J3W9m+TcHtkHxa7FRC5lsGAMoPpSQp40hEatDX2EvUj8LvtZpcr2chvsqBSoi74OHAd+DtZzlD1JuKziULNCZAf7wUoP6GVTSf6Z8TacNk/Xxf0DzJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771937240; c=relaxed/simple; bh=nch773hZQqgZOvBnPWaWve3zzwPQicazHmoLMVPntno=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=god8VlHOwwXqRgS/r9DAsu4J1nk3u/F9TFe0pJ4oVMFfviEfqobHjZ+L8SgMREp1czV0bTocEihMh1lxIt4EhWAdYi81nDq6sdF3h0d/72W9G0EnjLtl1WFuaz2caxRA7M5VwqrHbsFGGoW3mSsU+unTDCO6ccU3iebq1ea2cRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lWe+ya8x; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lWe+ya8x" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id A2A9EC143E1; Tue, 24 Feb 2026 12:47:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 170F45FD9D; Tue, 24 Feb 2026 12:47:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 384A81036805A; Tue, 24 Feb 2026 13:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1771937234; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=78YqTtbc0KnOyBfNAcTKTgrhawOApfzUONzGD1zf3LE=; b=lWe+ya8xPNaZAqdI/xTU8ovNoZIlk4t+prDLhCQLhsaOT4Z6Nc/ZtsgLsrLf913V7YsgwT 50JObj7YNm5SAVieHsNGRlYIn2Oqx4x3vuv9xoVsZ1pmq1WYQPt5OagV1hS41skBWkNizl OOQ3/qWdK6Uea0GrX6qc4M+RFUfmTf0lB/nRBcpy7G0R4rP/BPd+qTXYWjCqbmicL1nxNL 256EWaN4FhnePr+vewC2j+uhL+qTafYdzgwFtLNrQEvK52SrdYaz8q9R/vQGiSb0dDXpij m0lnWkh2aRqpybss5K8T7CnwccVUYaoLBf73MwiwgHayUnqVI3vObrsgR1AuXg== Date: Tue, 24 Feb 2026 13:47:11 +0100 From: Herve Codina To: Ioana Ciornei Cc: Thomas Gleixner , Linus Walleij , Geert Uytterhoeven , Alexander Stein , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Revert "irqchip/ls-extirq: Use for_each_of_imap_item iterator" Message-ID: <20260224134711.0b3483a1@bootlin.com> In-Reply-To: <20260224113610.1129022-2-ioana.ciornei@nxp.com> References: <20260224113610.1129022-1-ioana.ciornei@nxp.com> <20260224113610.1129022-2-ioana.ciornei@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Ioana, On Tue, 24 Feb 2026 13:36:09 +0200 Ioana Ciornei wrote: > This reverts commit 3ac6dfe3d7a2396602b67667249b146504dfbd2a. > > The ls-extirq uses interrupt-map but it's a non-standard use documented > in fsl,ls-extirq.yaml: > > # The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT > # function to parser interrupt-map. So it doesn't consider '#address-size' > # in parent interrupt controller, such as GIC. > # > # When dt-binding verify interrupt-map, item data matrix is spitted at > # incorrect position. Remove interrupt-map restriction because it always > # wrong. > > This means that by using for_each_of_imap_item and the underlying > of_irq_parse_imap_parent() on its interrupt-map property will > effectively break its functionality > > Revert the patch making use of for_each_of_imap_item() in ls-extirq. > > Fixes: 3ac6dfe3d7a2 ("irqchip/ls-extirq: Use for_each_of_imap_item iterator") > Signed-off-by: Ioana Ciornei > --- > drivers/irqchip/irq-ls-extirq.c | 47 +++++++++++++++++++++------------ > 1 file changed, 30 insertions(+), 17 deletions(-) Sorry for breaking it when I did 3ac6dfe3d7a2. I have missed this non-standard usage of interrupt-map. Acked-by: Herve Codina Best regards, Hervé