From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466132DB7A0 for ; Tue, 24 Feb 2026 12:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771937599; cv=none; b=MUKjGzG7nLORnNR9BCExwsTi8nBgYRgmSKF3y9yA/Yb5xqAGlpNfaOW628w99fLNob1FwT3gECOztvJApRXpUoWSn8+IT62KU0JfTVEbS1PuMzJGxM/F4JhMqd867Q1p+J0GV5xgdvLlcaS+PTVhSyx6gWwQSzbWDhiHX5MSmrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771937599; c=relaxed/simple; bh=Z8oJAsNInkiBNMrodOBnjfAAQtf5XmhGE4/gcIz7/CU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tv/pn73rIZxDlvyi3/kcM/j1c3SqtjYf6kBHPvUzHGC8BgHzKJpxW8LGHpVA9hGlgKjkM4wc/U0bRTbGCvZt57MwQWAR1rTGBMdSADSTo4yEb8+bhCV7ImGPsL6CTFB55fHFlQ7K9dV/eQVRF9XhlhL/kH39pJchtHCZkK5sT+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=R/SCZWOU; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="R/SCZWOU" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id BE8B11A1235; Tue, 24 Feb 2026 12:53:08 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9340E5FD9D; Tue, 24 Feb 2026 12:53:08 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BB0BE10369080; Tue, 24 Feb 2026 13:53:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1771937587; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ZGjvVB9XsVOmoMMa/AcTPIOMxzv2goLK3l4nSOehAgc=; b=R/SCZWOUZF+MivGMMyRZu8QSBQHf0c+bH4jjhGZOkF5ndHZzjD+9RJVtjQh6gBLE+G4RuO 71DFWzIGlw0WhXJT34/PcdGMaayd9dmZeJcpUkEbnK+3BGjUV/DlR0wcLiUGVG9Zqe5FFq WIZvN6FjAiR9T3PtS3Pr0BqEJQIhdyPdIQpETEwuSFR3LnG2cv4hvSdYwd4XBeRJLDZp2u Ryse4xoaSAoHvTpvrnFYVYjybMySnvUR7QiBkCsKbI80cs583Xjze2KpPe9RqUhnkc+F98 Gb7feGZj/oaDmPcEZXhCtRFDvSQ4In/E4gU0PcEtdKz78MmEyp9DYfYUJ7NTYA== Date: Tue, 24 Feb 2026 13:53:05 +0100 From: Herve Codina To: Ioana Ciornei Cc: Thomas Gleixner , Linus Walleij , Geert Uytterhoeven , Alexander Stein , linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH 2/2] irqchip/ls-extirq: fix devm_of_iomap() error check Message-ID: <20260224135305.7a364f39@bootlin.com> In-Reply-To: <20260224113610.1129022-3-ioana.ciornei@nxp.com> References: <20260224113610.1129022-1-ioana.ciornei@nxp.com> <20260224113610.1129022-3-ioana.ciornei@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Ioana, On Tue, 24 Feb 2026 13:36:10 +0200 Ioana Ciornei wrote: > The devm_of_iomap() function returns an ERR_PTR() encoded error code on > failure. Replace the incorrect check against NULL with IS_ERR(). > > Fixes: 05cd654829dd ("irqchip/ls-extirq: Convert to a platform driver to make it work again") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/aYXvfbfT6w0TMsXS@stanley.mountain/ > Signed-off-by: Ioana Ciornei Reviewed-by: Herve Codina Best regards, Hervé