Re: [PATCH v5 3/5] iio: accel: adxl345: Expose IIO_EV_INFO_VALUE for double tap

Andy Shevchenko
2026-02-24T14:55:49Z

On Tue, Feb 24, 2026 at 02:03:46PM +0000, Taha Ed-Dafili wrote:
> The ADXL345 uses a single hardware register (ADXL345_REG_THRESH_TAP) to
> store the threshold for both single tap and double tap events.
>
> Currently, the driver only exposes the IIO_EV_INFO_VALUE attribute for
> the single tap event.
>
> However, the IIO ABI dictates that if an event is supported, its
> associated configuration attributes should be exposed to userspace. This
> applies even if writing to one channel property alters the value of
> another due to shared underlying hardware state.
>
> Add IIO_EV_INFO_VALUE to the double tap event specification to ensure
> full ABI compliance.

...

> - BIT(IIO_EV_INFO_RESET_TIMEOUT) |

> + BIT(IIO_EV_INFO_RESET_TIMEOUT) |

I do not see a reason why the amount of spaces should be increased.
The original one space is a gold standard in such cases as it makes
independent on the line length. With the formatted | it becomes a
burden for maintenance: each time one adds longer line, all lines
need to be adjusted for no good reason.

--
With Best Regards,
Andy Shevchenko