From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB8F2264CA
	for <linux-kernel@vger.kernel.org>; Tue, 24 Feb 2026 14:30:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771943444; cv=none; b=nEkvuB2T2s2Fd8n2/vT4nWU9vIIvkQ5jgDH52Nm6W3xdE23P5wER1FSbctrusiNrIUcy0oHl8y6r1C175VfWdBW/MhGXo0wiGL2R04u+6S9+SItHbNyeGIz45ZjsdrPTXcmqLxusm3+Zk6JNe+4EO8Nv/fdcUhMHXhn0Q4yGt8w=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771943444; c=relaxed/simple;
	bh=ycNZwipHtdS5xkDqo4y0z4kq9MAco7LD8RddfprPqmk=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=dSaNpBQ0K1titnHhk9rhzvgFB3jF1LFiAzPRpKzPRK0wmWPhP7T6PKebgnEWwZTeRE4oFR/tG4Utws2ZAZvvHpcINO3AEPmipLeLUhTXfvBcbWHPoZwmEJRPMQ/yY9nEtfjJDpC0pJVtZEN72wrMENfP/HEkCynA1cTq66CDblI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 9F99D68C7B; Tue, 24 Feb 2026 15:30:40 +0100 (CET)
Date: Tue, 24 Feb 2026 15:30:40 +0100
From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] nvme: update nvme_id_ns OPTPERF constants
Message-ID: <20260224143040.GB11710@lst.de>
References: <20260221033302.1451669-1-csander@purestorage.com> <20260221033302.1451669-4-csander@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260221033302.1451669-4-csander@purestorage.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

> In NVMe verson 2.0 and below, OPTPERF comprises only bit 4 of NSFEAT in
> the Identify Namespace structure. Since version 2.1, OPTPERF includes
> both bits 4 and 5 of NSFEAT. Replace the NVME_NS_FEAT_IO_OPT constant
> with NVME_NS_FEAT_OPTPERF_SHIFT, NVME_NS_FEAT_OPTPERF_MASK, and
> NVME_NS_FEAT_OPTPERF_MASK_2_1, representing the first bit, pre-2.1 bit
> width, and post-2.1 bit width of OPTPERF.

Please add this in a comment in the code.