From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FCF3A9DAF for ; Tue, 24 Feb 2026 16:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952109; cv=none; b=p8HFXlBYrpYHrQnGVL8sBE/1I3hGoridxitZxg6m56UR72q5CJYTlKSACmZie4qH3+2rELGdBxwvej6YKwp9sCOiZFdP+s3mq21avOW8jv5miOEVJtC8dG7/NFDi17FbXlfebqNT07gdXGozHKws1N54xWtI6ZhIOpzikna55Ss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771952109; c=relaxed/simple; bh=6D2xm2u7a0Ard8UD5jhMoGvejwPvgyeFwzrZ6ep9k/s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ry7jNC8LNu8fbWmT3t4+XTyD4TizvLvVGa687Nj43EadNYaRs66oUp6kiacS5IkcvfFYp++2pgtaefsQjpGjhPziBSM222yDCjGrhNI8LCNqrwa0DPzdhBHFCDmTCJhBMkUF0DpOuNOMI8onGcEu7FlsNfjrClTaRIqT/p0L6oQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b5lf/U2e; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b5lf/U2e" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2aae4816912so39891925ad.2 for ; Tue, 24 Feb 2026 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771952107; x=1772556907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/dk99oPBkOKQC4NJdNNbbUKUujZV8OZzxFj2+2UXmSY=; b=b5lf/U2e+Fzcg26x6XgKDfQlnHZEW4cshIEkFjtlRi33fVqo5AS8ha4h8ABOtZaB/U xy3UjcOwnWvjtcqFAtYbVsdOSgn/SClA3t5l1GSkiwGooJgqJj13kPmriGJdwpAAMPU0 ipfXes1XdEzintpKmD+dZ1jBjI1Ccek1GDWOmFy8nFJIsA3TN2EKzryC52qYNvvm0iQJ ADF33DVBdCTyGSSmS0GtWDIBtNv2PO5i1yeDJcTsQi1YEZ5vOJIJOk7BFQrfd3Rgm8Vm yW40PBck7HXrZmRw+QFJdhc9aD9nKm8kETdQg8BN4rEvo/dwlm2Sl0tot9aJnhrpakmZ n3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771952107; x=1772556907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/dk99oPBkOKQC4NJdNNbbUKUujZV8OZzxFj2+2UXmSY=; b=FczkP+q26oVfEpu3VZNPRqVoqVB4jhutgW/FWCAhEJduFM1dZu1s7CKuUBoSNjZfmL 6hR8iTvzZASgIEWbK3AKeCzGxXFXME3pGpuHv0Q9BvfgX2uLWBnsrzeJdx0k+bQiXZMp Wdbbo02Mii3IyZzoSV6sqbZxqOgowt2bm4flEeq6Fe1tCrR79MyBeR+A+dqrmj7rwuoy T8RpTfEXqmy/Kud1bDrBKuBM0+XPiqW2PjlFoV4/wjafH9vt9+omshYc98qE4UDLo3se Lo41QnrFx4s2VGtT3cHd6Q6LeZn0ovCXjksruHz/SW4vDDOYUm0mxWitIYofqfCPLzXI mETw== X-Forwarded-Encrypted: i=1; AJvYcCWOOvkve6bX9gI2/NnfM1sq/uoX1uPQ19ljVi6f8gKXfiQm1LXkoupCnc0NkT++Xggq+TxPgMgs8Eoaa+E=@vger.kernel.org X-Gm-Message-State: AOJu0YzwiBk0P7ddiUFyCyvL5pmfZFaUsN2oBa0O2cFOW8ClUUyp3gr2 x5t0UhoyCsoM76PDSsmnlIxNXwXYNLuyijUklypPn9z3tx4fh2QFVc7s X-Gm-Gg: ATEYQzzkkvg/3wJq+T5N09xpadkyamuoxzlSDcm1ZwcQVNG2HHLuMCqraItylrOHN// MA2BPrIw3T8rv+5cHhlrJi98pSGwTaA9y4JLTLDiidTSYsh1mmtCSDktT+ZUlECsZaO3O4dK6IS M8GKj6UujbGuunSiaPwbiQ4d2VvBIL6vDMJTmTi/sMvSqLZta7BNmoRDQ6tS2Vq1w9WQUMFJ2IO RorllGc3MOvXSYKjyoMVc046Kf0m3PlwI/apaVzEk1HOrCAKKUDmjZXkshRn/+CzngMd+opJMrK EB7ZXFK0GrWF6/XFV3w9u/0u697HFFuHmQbXJmuC/WY1zsNbw/BbAiGkAaiEg7TprEc+J29d6ES N5T3l9ZIgS+2wmFhyHp1rtzM3uKx+5m9+7MrSlQkkkmbW6gcWJ9zCr/IxgsJ+JHxJ9HF0Z8RExF jllpaBn6IhDaWbYMQD1y7y1ZkzJmrl/5nZH8l3XxMXfSqJqOff8obkc6K3mgttYhQz9nQNkKPX1 Q== X-Received: by 2002:a17:903:285:b0:2ab:2bc5:4365 with SMTP id d9443c01a7336-2ad74464438mr87550565ad.19.1771952107313; Tue, 24 Feb 2026 08:55:07 -0800 (PST) Received: from sean-All-Series.. (59-115-199-112.dynamic-ip.hinet.net. [59.115.199.112]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b7256f32sm12364083a12.27.2026.02.24.08.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 08:55:06 -0800 (PST) From: Sean Chang To: Andrew Lunn , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v3 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Wed, 25 Feb 2026 00:54:35 +0800 Message-Id: <20260224165435.17648-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260224165435.17648-1-seanwascoding@gmail.com> References: <20260224165435.17648-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Signed-off-by: Sean Chang --- drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 43cd013bb70e..616823e9fc5b 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev, int sset) static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp = netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,10 +3157,8 @@ static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i = 0; i < QUEUE_STATS_LEN; i++, p += ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); + for (i = 0; i < QUEUE_STATS_LEN; i++) { + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } } break; -- 2.34.1