public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: tomasz.unger@yahoo.pl, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format
Date: Tue, 24 Feb 2026 09:59:56 -0800	[thread overview]
Message-ID: <2026022431-splotchy-prison-d68a@gregkh> (raw)
In-Reply-To: <DGMXXS3DIY2Z.3GUN0MJI6S15M@gmail.com>

On Mon, Feb 23, 2026 at 11:25:47PM -0600, Ethan Tidmore wrote:
> On Mon Feb 23, 2026 at 2:00 PM CST, tomasz.unger wrote:
> > From: Tomasz Unger <tomasz.unger@yahoo.pl>
> >
> > Convert a long single-line comment to multi-line format
> > as per coding-style.rst.
> >
> > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> > ---
> > v3: Split into two separate patches as requested by Greg Kroah-Hartman.
> > v2: Added multi-line comment format, changed to codespell.
> >
> >  drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> > index 74c31a97f093..cffb1a9d36fa 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> > @@ -597,7 +597,9 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid)
> >  
> >  		i = _rtw_camid_search(adapter, addr, kid);
> >  		if (i >= 0) {
> > -			/* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */
> > +			/* Fix issue that pairwise and group key have same key id.
> > +			 * Pairwise key first, group key can overwrite group only(ex: rekey)
> > +			 */
> 
> Almost, the correct format is this:
> 
> /*
>  * Fix issue ...
>  * ...
>  */ 

Except for the network stack/drivers.  So this _is_ correct, as this is
a network driver.

thanks,

greg k-h

  reply	other threads:[~2026-02-24 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260223200006.145296-1-tomasz.unger.ref@yahoo.pl>
2026-02-23 20:00 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c tomasz.unger
2026-02-23 20:00   ` [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format tomasz.unger
2026-02-24  5:25     ` Ethan Tidmore
2026-02-24 17:59       ` Greg KH [this message]
2026-02-24 18:54         ` Ethan Tidmore
2026-02-24  5:22   ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026022431-splotchy-prison-d68a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ethantidmore06@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=tomasz.unger@yahoo.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox