From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E517F1EA7CB for ; Wed, 25 Feb 2026 02:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771985928; cv=none; b=MchicECEyjdFu4nu6n44xSOP7l6E1YYFuI710pe1ZA/GOY0Htj30xqNztO0KZOK0gvMHasnZUYlueXTvchww1Y5Rulf21R6ncEr8VrhF/d+6FaItpGeIeGTb+dGIZIBLAUO0hxxoEaj/ymcKVFaATvF2x6EdZSGqTKIymViYwDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771985928; c=relaxed/simple; bh=pgGwTfKR7p0Pg1mQDrXTYVdAt7ugAKMcZvy4poegARo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JJ6GRB5lBZ4vaqYZAE6vAHk3VbMWwMyOfnQOabrk2v8HcbeZqgiLzeGNYiiCyhovmzGPnMFvufeQFXQiMvyC0yXUeTaz7gCjpPftNadqXtZw/ua/GBmycUjKAZapKOIrQxaABurHDu43Can8MRQZp6Kb++In9zD9RKhmluM0DSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bPgY+6D3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bPgY+6D3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F069EC116D0; Wed, 25 Feb 2026 02:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771985927; bh=pgGwTfKR7p0Pg1mQDrXTYVdAt7ugAKMcZvy4poegARo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bPgY+6D3XEsxQVtjGvB7wDbUfhWwzui3Y/JlgKxZ36khQyGXBGBWlLr4gvdj0BXR8 I2PbLV/nDqh92Ovimbj7vNIoyvolHPoWhp/f3jVjG7QQZAK6KPeIt8i0tucEjxzGcy ElmUouSH6xdjK8PYgPMVOgls22QPpAayKAK44pYbk8FqUMOKG1BGR2zr+zlsuOurqw liXbPkA14ZHulFzMF9m0LmpGN3WQU3xkBao2tah4Tc1AWYXO/IsUsCeNlWzpk24QPR epL9xBjfnOoaGFMQdevnKAu1vkFqlNNO/zqx6OTv4JYDiZHea+rtHuHyWF/NV8O4uM VKD7+zTziKsKA== From: SeongJae Park To: Zi Yan Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ron Economos Subject: Re: [PATCH] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release() Date: Tue, 24 Feb 2026 18:18:44 -0800 Message-ID: <20260225021845.62875-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260224213946.2328419-1-ziy@nvidia.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 24 Feb 2026 16:39:46 -0500 Zi Yan wrote: > When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement > with side effect inside it is incorrect. Move put_page_testzero() out and > check its return value in VM_WARN_ON. Add __maybe_unused to the return > value for when CONFIG_DEBUG_VM is not set. > > Fixes: 9bda131c6093 ("mm: cma: add cma_alloc_frozen{_compound}()") > Reported-by: Ron Economos > Closes: https://lore.kernel.org/all/1b17c38f-30d3-4bb4-a7e1-e74b19ada885@w6rz.net/ > Signed-off-by: Zi Yan Reviewed-by: SeongJae Park Thanks, SJ [...]