From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2124C27F73A
	for <linux-kernel@vger.kernel.org>; Wed, 25 Feb 2026 02:20:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771986014; cv=none; b=iYIl41fPDDBwrjn/JouENddjuO3ErxUX9vCR7BNCwmrrI04cqp/Nrze7rrAXBQT+Zs1qmSJdiuNl8xVQBfivoQg0i6d3NtDJKjfkMhkw30Qyi406OopXoOVP7iTD2NUnI/CBPASTmIdj1p5ZSxZx0Mt7Udue1eC1s6G2Z5dicrU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771986014; c=relaxed/simple;
	bh=XyqpMwamYA5lYABslMLEGD29LgjL8i6ehyfSd50lnn4=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=FJph5IbfBBfQJK625r7Lbd+hqW3yyv9h5Q6Z1sdXZi47IBDj9bRoQ8zbqJ2CosF4dFF8FSkh/JyGh/Ph0+OLKq16+R0UxJq2w8j66ZF0Df96260Ksxwy4icj6FfMuay3IU8sRceo+3edo8E/CHREWBv6i3n7uX+kyic5go8IyNY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jiKF/K2T; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jiKF/K2T"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58A21C116D0;
	Wed, 25 Feb 2026 02:20:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1771986013;
	bh=XyqpMwamYA5lYABslMLEGD29LgjL8i6ehyfSd50lnn4=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=jiKF/K2TFJl1pG18BdvcxbxfLEtRm8h7SE8vqoy+x52pTd1k/el/OeUNw8yvm0M1/
	 uDIkvYXYvd8xh1KM9OS8VXM6M+jQHFR/+CVbh1hlVvt5fk+dTSX1k7RrQ6KdNs8Owb
	 goeft+JLJtTofPLdv2RYLfzIy+Vcm6C9ugkmO5g4wie5hvLFKzjWln/rjyKlZ+UHoh
	 B875aPStUNB1tSER9gCLoZtvtxvjstN6c917yHVO5kONmtqZVDRhnIENUL4+P3kPDF
	 x6Dp8pae1Pzdn/CMYRphrl1zYIihZwSdSCWjlFpmmBp82n7uxNxmLO83317B86nDQe
	 0PAmQlqKcVPVA==
From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: Zi Yan <ziy@nvidia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Ron Economos <re@w6rz.net>
Subject: Re: [PATCH] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release()
Date: Tue, 24 Feb 2026 18:20:11 -0800
Message-ID: <20260225022012.62985-1-sj@kernel.org>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260225021845.62875-1-sj@kernel.org>
References: 
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Tue, 24 Feb 2026 18:18:44 -0800 SeongJae Park <sj@kernel.org> wrote:

> On Tue, 24 Feb 2026 16:39:46 -0500 Zi Yan <ziy@nvidia.com> wrote:
> 
> > When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement
> > with side effect inside it is incorrect. Move put_page_testzero() out and
> > check its return value in VM_WARN_ON. Add __maybe_unused to the return
> > value for when CONFIG_DEBUG_VM is not set.
> > 
> > Fixes: 9bda131c6093 ("mm: cma: add cma_alloc_frozen{_compound}()")
> > Reported-by: Ron Economos <re@w6rz.net>
> > Closes: https://lore.kernel.org/all/1b17c38f-30d3-4bb4-a7e1-e74b19ada885@w6rz.net/

I forgot asking this, sorry.

Should we Cc stable@ ?


Thanks,
SJ

[...]