* [PATCH] rds: update outdated comment
@ 2026-02-24 2:07 kexinsun
2026-02-25 3:03 ` Allison Henderson
2026-02-26 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: kexinsun @ 2026-02-24 2:07 UTC (permalink / raw)
To: allison.henderson
Cc: davem, edumazet, kuba, pabeni, horms, netdev, linux-rdma,
rds-devel, linux-kernel, julia.lawall, xutong.ma, yunbolyu,
ratnadiraw, kexinsun
The function rds_send_reset() was subsumed by rds_send_path_reset()
by commit d769ef81d5b5 ("RDS: Update rds_conn_shutdown to work with
rds_conn_path"). Update the comment accordingly.
Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
net/rds/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/send.c b/net/rds/send.c
index a1039e422a38..d8b14ff9d366 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -284,7 +284,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
*
* cp_xmit_rm holds a ref while we're sending this message down
* the connection. We can use this ref while holding the
- * send_sem.. rds_send_reset() is serialized with it.
+ * send_sem.. rds_send_path_reset() is serialized with it.
*/
if (!rm) {
unsigned int len;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: update outdated comment
2026-02-24 2:07 [PATCH] rds: update outdated comment kexinsun
@ 2026-02-25 3:03 ` Allison Henderson
2026-02-26 3:05 ` Jakub Kicinski
2026-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Allison Henderson @ 2026-02-25 3:03 UTC (permalink / raw)
To: kexinsun@smail.nju.edu.cn
Cc: linux-rdma@vger.kernel.org, yunbolyu@smu.edu.sg,
davem@davemloft.net, ratnadiraw@smu.edu.sg,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
julia.lawall@inria.fr, pabeni@redhat.com, horms@kernel.org,
edumazet@google.com, kuba@kernel.org, xutong.ma@inria.fr,
netdev@vger.kernel.org
On Tue, 2026-02-24 at 10:07 +0800, kexinsun wrote:
> The function rds_send_reset() was subsumed by rds_send_path_reset()
> by commit d769ef81d5b5 ("RDS: Update rds_conn_shutdown to work with
> rds_conn_path"). Update the comment accordingly.
>
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
> net/rds/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/send.c b/net/rds/send.c
> index a1039e422a38..d8b14ff9d366 100644
> --- a/net/rds/send.c
> +++ b/net/rds/send.c
> @@ -284,7 +284,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
> *
> * cp_xmit_rm holds a ref while we're sending this message down
> * the connection. We can use this ref while holding the
> - * send_sem.. rds_send_reset() is serialized with it.
> + * send_sem.. rds_send_path_reset() is serialized with it.
> */
> if (!rm) {
> unsigned int len;
Hi kexinsun,
Thanks for the catch. Just one small nit: Your patch should specify the target
branch, version and component like this:
[PATCH net-next v2] net/rds: update outdated comment in rds_send_xmit
Other than that, this patch looks pretty straight forward. Thank you!
Allison
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: update outdated comment
2026-02-25 3:03 ` Allison Henderson
@ 2026-02-26 3:05 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2026-02-26 3:05 UTC (permalink / raw)
To: kexinsun@smail.nju.edu.cn
Cc: Allison Henderson, linux-rdma@vger.kernel.org,
yunbolyu@smu.edu.sg, davem@davemloft.net, ratnadiraw@smu.edu.sg,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
julia.lawall@inria.fr, pabeni@redhat.com, horms@kernel.org,
edumazet@google.com, xutong.ma@inria.fr, netdev@vger.kernel.org
On Wed, 25 Feb 2026 03:03:10 +0000 Allison Henderson wrote:
> Thanks for the catch. Just one small nit: Your patch should specify the target
> branch, version and component like this:
>
> [PATCH net-next v2] net/rds: update outdated comment in rds_send_xmit
That's right, please try to remember the tree name in the future.
Since net-next is our default tree anyway, there's no need to repost
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: update outdated comment
2026-02-24 2:07 [PATCH] rds: update outdated comment kexinsun
2026-02-25 3:03 ` Allison Henderson
@ 2026-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-26 3:10 UTC (permalink / raw)
To: Kexin Sun
Cc: allison.henderson, davem, edumazet, kuba, pabeni, horms, netdev,
linux-rdma, rds-devel, linux-kernel, julia.lawall, xutong.ma,
yunbolyu, ratnadiraw
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 24 Feb 2026 10:07:20 +0800 you wrote:
> The function rds_send_reset() was subsumed by rds_send_path_reset()
> by commit d769ef81d5b5 ("RDS: Update rds_conn_shutdown to work with
> rds_conn_path"). Update the comment accordingly.
>
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
> net/rds/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- rds: update outdated comment
https://git.kernel.org/netdev/net-next/c/51432958b565
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-26 3:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 2:07 [PATCH] rds: update outdated comment kexinsun
2026-02-25 3:03 ` Allison Henderson
2026-02-26 3:05 ` Jakub Kicinski
2026-02-26 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox