* [RESEND PATCH] ice: access @pp through netmem_desc instead of page
@ 2026-02-24 5:35 Byungchul Park
2026-02-26 1:08 ` Byungchul Park
0 siblings, 1 reply; 3+ messages in thread
From: Byungchul Park @ 2026-02-24 5:35 UTC (permalink / raw)
To: netdev, kuba
Cc: linux-kernel, kernel_team, harry.yoo, david, willy, toke,
asml.silence, almasrymina, anthony.l.nguyen, przemyslaw.kitszel,
andrew+netdev, davem, edumazet, pabeni, intel-wired-lan
To eliminate the use of struct page in page pool, the page pool users
should use netmem descriptor and APIs instead.
Make ice driver access @pp through netmem_desc instead of page.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index c6bc29cfb8e6..c16e54dbe75b 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
rx_buf = &rx_ring->rx_fqes[i];
page = __netmem_to_page(rx_buf->netmem);
received_buf = page_address(page) + rx_buf->offset +
- page->pp->p.offset;
+ pp_page_to_nmdesc(page)->pp->p.offset;
if (ice_lbtest_check_frame(received_buf))
valid_frames++;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page
2026-02-24 5:35 [RESEND PATCH] ice: access @pp through netmem_desc instead of page Byungchul Park
@ 2026-02-26 1:08 ` Byungchul Park
2026-02-26 18:13 ` Tony Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Byungchul Park @ 2026-02-26 1:08 UTC (permalink / raw)
To: netdev, kuba
Cc: linux-kernel, kernel_team, harry.yoo, david, willy, toke,
asml.silence, almasrymina, anthony.l.nguyen, przemyslaw.kitszel,
andrew+netdev, davem, edumazet, pabeni, intel-wired-lan
On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
> To eliminate the use of struct page in page pool, the page pool users
> should use netmem descriptor and APIs instead.
>
> Make ice driver access @pp through netmem_desc instead of page.
Hi Tony and Przemek,
Is there something that I'm missing or something wrong with this? Your
feedback would be appreciated. Thanks!
Byungchul
> Signed-off-by: Byungchul Park <byungchul@sk.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index c6bc29cfb8e6..c16e54dbe75b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> rx_buf = &rx_ring->rx_fqes[i];
> page = __netmem_to_page(rx_buf->netmem);
> received_buf = page_address(page) + rx_buf->offset +
> - page->pp->p.offset;
> + pp_page_to_nmdesc(page)->pp->p.offset;
>
> if (ice_lbtest_check_frame(received_buf))
> valid_frames++;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page
2026-02-26 1:08 ` Byungchul Park
@ 2026-02-26 18:13 ` Tony Nguyen
0 siblings, 0 replies; 3+ messages in thread
From: Tony Nguyen @ 2026-02-26 18:13 UTC (permalink / raw)
To: Byungchul Park, netdev, kuba
Cc: linux-kernel, kernel_team, harry.yoo, david, willy, toke,
asml.silence, almasrymina, przemyslaw.kitszel, andrew+netdev,
davem, edumazet, pabeni, intel-wired-lan
On 2/25/2026 5:08 PM, Byungchul Park wrote:
> On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
>> To eliminate the use of struct page in page pool, the page pool users
>> should use netmem descriptor and APIs instead.
>>
>> Make ice driver access @pp through netmem_desc instead of page.
>
> Hi Tony and Przemek,
>
> Is there something that I'm missing or something wrong with this? Your
> feedback would be appreciated. Thanks!
Hi Byungchul,
Nothing wrong. I plan to apply it today.
Thanks,
Tony
> Byungchul
>
>> Signed-off-by: Byungchul Park <byungchul@sk.com>
>> ---
>> drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> index c6bc29cfb8e6..c16e54dbe75b 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
>> rx_buf = &rx_ring->rx_fqes[i];
>> page = __netmem_to_page(rx_buf->netmem);
>> received_buf = page_address(page) + rx_buf->offset +
>> - page->pp->p.offset;
>> + pp_page_to_nmdesc(page)->pp->p.offset;
>>
>> if (ice_lbtest_check_frame(received_buf))
>> valid_frames++;
>> --
>> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-26 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 5:35 [RESEND PATCH] ice: access @pp through netmem_desc instead of page Byungchul Park
2026-02-26 1:08 ` Byungchul Park
2026-02-26 18:13 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox