From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A328836EAB7 for ; Thu, 26 Feb 2026 15:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772118685; cv=none; b=MeFKY5TdLiZ4jB8kuYiu48PvWSXv4sdqTkTuDgqAGeS1e8Gg0ivPFDP8ykpD8i15OEVxE5gF9pjYGFm2PsLAHK22XlffVtUwqeX5AiWI6tSsgfk4WiSCuZBK98kvUwmk2YP3SlsGD7kpVlxKjKHY447gqgjt3r9KMo8lNxzP5ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772118685; c=relaxed/simple; bh=NNWTiEb//BrzQ/xGozL9s9RqDOS1KYPUzlwFVG2TNDA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z3O1imdXYxeCQW7Ablq7ntvS1sHXplozIaiIxj1CQy8p3tvvgevvao+FYC0NP1azn3dShvyhnbEngzdSzj5Q3+RwqRGB91c51CN6qCRZr/oWZMgtgAnHTdJIOW8z0Vr1j4rRzW0/Ad7CiaAb/yPxYn+4RAfXmEUy847OEsfdd38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iyRelujL; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iyRelujL" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-896f82e5961so14243356d6.0 for ; Thu, 26 Feb 2026 07:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772118684; x=1772723484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4+TBrmc0fLXcmkm0VaaldSqs2PcXgyH2nxurKdQgp9Y=; b=iyRelujLQxQalRlxdGj27+QL+6ETlNkXWwxxgpW8LruqdUVmCOVor28GPNJRMvSgFA IwXd9wRwo5PldLqP0XEetMOGc/RgXzYFj4IV/lnScG1/8Huja+bvB0QbARlyvGad+xIX NdpuWH5VQ5pxuELSyKNawbziendaXLptybFIGCuERUeX+TSyxT2VFMH+NEVaVPuNaFMR yqhBs2raARgmS6RkFl/sMg014/2suHf/xx0GjhXxv1Hzrib8HzUFCfxTUT2I5ZwM/A8P mZnZzQwF9DVw/6yfxRo6x+n+BjjbOsfgiWsR6glgmCuqs2F21HZvc+EgDTQIG2PG3zN/ qTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772118684; x=1772723484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4+TBrmc0fLXcmkm0VaaldSqs2PcXgyH2nxurKdQgp9Y=; b=tPIiNVvtbl7dN6khH06KdbUKR7e6+Vk1G7HQcPUAON+tuvHbLJETGW3kCgwGUS8/nn 3RPYA1Jh/zVTQMkO9uCK9ngtg5YcoMSvZpPY+ZO9HRfvcwxmodyT6UonSd7mv+uCSpbU URANDwB0XN7ZyyezFhHP9dl+/kOC5Ay71Quh+oyY+UKf+mX9QhqBjPNkjgI7sAcy2vL3 FaeYg1uMJaPugYLY6VhLn72gM1iaHSkbWhtoIkR+Rclg9aVOxdCIWi7489eW0lkQBrjo 6QmGVNiVFaHOo7aCWOfwJ2GktoRMaCAFnF6ofxjB//Aw5ZrS/uI2ktmkVbmoDnSZp9fx mAkA== X-Forwarded-Encrypted: i=1; AJvYcCVEzqj2TnrDx1yZcmPlDCJk1eILAbv4IBvUqvtgH5ktK16f7ElLhDxQBrmwSiQWaIW+js3qYYLEFtbngIA=@vger.kernel.org X-Gm-Message-State: AOJu0YwEkzXw6HwPQjnOfS4RG3E0hkPdvRzd5wj0/Hn/GcSb+RXFbWWx svam277ViX8zSO5D7CLNqIeqZKERAK75TisyLf9/62lJv1T/nsRWoJLN X-Gm-Gg: ATEYQzy9dlw2OJhG99OhDUwpRxJiQPyoFNUVg18YrvrHomCEM4N97jOuFR/KmXjt3qe e/PzN+ztdUI1ChiWcxvsUOKOpryYI+1fXNxaT03hR7m9WmnVlsGNVqugG8vrun1poE41IHRPRXW C595m8rAXEWaNgC5GghzEdVkijigymmDz3A0b2JcZsz3MoQnrRM+BY9BkUcxUtzFLBPf8Le22GS bE4E5nRMlEL/3VNeTzel46itEjzRjpt22upBBIu1Vo2sOZf7U4BMA5Ny5hI4HpJNs1AeX50jSE3 CUIDJsr1mnFkYQx3bq2NgZ2AsRhUs9O8s9iP2pzQN4/VeBdpZeIwFUlyEVxINlkJ55uYhZOHVIm qe8xenZsYpYFGXpYjU9FeFpbRyPMfnTZkhAFZ4TllKW6afjCWmGAhVK6S/SOXJC2bqnAzx5MBAN G6yv+Decm8gprtBwt4dIVR7n5CSQATiYhAcSO3aTKoIRzqgiBhjh7YcIKAjK409A== X-Received: by 2002:a05:6214:1bcb:b0:899:bdae:beb2 with SMTP id 6a1803df08f44-899c13fea0bmr67244086d6.24.1772118683547; Thu, 26 Feb 2026 07:11:23 -0800 (PST) Received: from db07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c738e661sm19275136d6.43.2026.02.26.07.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 07:11:23 -0800 (PST) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: linux-iio@vger.kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, rdunlap@infradead.org, skhan@linuxfoundation.org, nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net, lars@metafoo.de, Michael.Hennerich@analog.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v6 3/5] iio: accel: adxl345: Expose IIO_EV_INFO_VALUE for double tap Date: Thu, 26 Feb 2026 15:11:04 +0000 Message-ID: <20260226151108.22383-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260226151108.22383-1-0rayn.dev@gmail.com> References: <20260226151108.22383-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ADXL345 uses a single hardware register (ADXL345_REG_THRESH_TAP) to store the threshold for both single tap and double tap events. Currently, the driver only exposes the IIO_EV_INFO_VALUE attribute for the single tap event. However, the IIO ABI dictates that if an event is supported, its associated configuration attributes should be exposed to userspace. This applies even if writing to one channel property alters the value of another due to shared underlying hardware state. Add IIO_EV_INFO_VALUE to the double tap event specification to ensure full ABI compliance. Suggested-by: Jonathan Cameron Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/accel/adxl345_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c index 78e3f799ecc1..96d1417d77c6 100644 --- a/drivers/iio/accel/adxl345_core.c +++ b/drivers/iio/accel/adxl345_core.c @@ -235,7 +235,9 @@ static const struct iio_event_spec adxl345_events[] = { /* double tap */ .type = IIO_EV_TYPE_GESTURE, .dir = IIO_EV_DIR_DOUBLETAP, - .mask_shared_by_type = BIT(IIO_EV_INFO_ENABLE) | + .mask_shared_by_type = + BIT(IIO_EV_INFO_ENABLE) | + BIT(IIO_EV_INFO_VALUE) | BIT(IIO_EV_INFO_RESET_TIMEOUT) | BIT(IIO_EV_INFO_TAP2_MIN_DELAY), }, -- 2.47.3