From: hch <hch@lst.de>
To: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Cc: "djwong@kernel.org" <djwong@kernel.org>, hch <hch@lst.de>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cem@kernel.org" <cem@kernel.org>
Subject: Re: [PATCH] xfs: add write pointer to xfs_rtgroup_geometry
Date: Fri, 27 Feb 2026 14:52:33 +0100 [thread overview]
Message-ID: <20260227135233.GA20671@lst.de> (raw)
In-Reply-To: <dbda17987ff33a132da82b8635ac2a5c6ae01c78.camel@wdc.com>
On Fri, Feb 27, 2026 at 05:16:39AM +0000, Wilfred Mallawa wrote:
> > > - __u32 rg_reserved[27]; /* o: zero */
> > > + __u32 rg_reserved0; /* o: preserve alignment */
> > > + __u64 rg_writepointer; /* o: write pointer sector for
> > > zoned */
> >
> > Hrm. It's not possible to advance the write pointer less than a
> > single
> > xfs fsblock, right?
>
> I believe so, perhaps Christoph could chime in?
It's not possible.
>
> > zoned rt requires rt groups, so that means the
> > write pointer within a rtgroup has to be a xfs_rgblock_t (32bit)
> > value,
> > so shouldn't this be a __u32 field?
>
> I figured since this is currently returning a basic block offset
> (similar to a zone report from a zoned device), it *could* exceed a
> U32_MAX for larger zones (?). Does it seem more appropriate to return
> the xfs fsblock offset here instead?
No, the count of blocks in a zone is a xfs_rgblock_t, which is a
uint32_t. So all group/zone relative addressing can and should use
32-bit types.
prev parent reply other threads:[~2026-02-27 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 3:01 [PATCH] xfs: add write pointer to xfs_rtgroup_geometry Wilfred Mallawa
2026-02-27 4:06 ` Darrick J. Wong
2026-02-27 5:16 ` Wilfred Mallawa
2026-02-27 13:52 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227135233.GA20671@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox