public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Carlier <devnexen@gmail.com>
To: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>
Cc: linux-kernel@vger.kernel.org, David Carlier <devnexen@gmail.com>
Subject: [PATCH] tools/sched_ext: fix strtoul() misuse in scx_hotplug_seq()
Date: Fri, 27 Feb 2026 18:14:39 +0000	[thread overview]
Message-ID: <20260227181439.10323-1-devnexen@gmail.com> (raw)

scx_hotplug_seq() uses strtoul() to parse the hotplug sequence number
but checks the result with val < 0. Since strtoul() returns an unsigned
long, it never produces a negative value, making the validation dead
code.

Switch to strtol() so the negative check is meaningful and fix the
format specifier from %lu to %ld to match the long type of val.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 tools/sched_ext/include/scx/compat.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/sched_ext/include/scx/compat.h b/tools/sched_ext/include/scx/compat.h
index 8b4897fc8b99..1518d05d3e21 100644
--- a/tools/sched_ext/include/scx/compat.h
+++ b/tools/sched_ext/include/scx/compat.h
@@ -137,8 +137,8 @@ static inline long scx_hotplug_seq(void)
 	buf[len] = 0;
 	close(fd);
 
-	val = strtoul(buf, NULL, 10);
-	SCX_BUG_ON(val < 0, "invalid num hotplug events: %lu", val);
+	val = strtol(buf, NULL, 10);
+	SCX_BUG_ON(val < 0, "invalid num hotplug events: %ld", val);
 
 	return val;
 }
-- 
2.51.0


             reply	other threads:[~2026-02-27 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 18:14 David Carlier [this message]
2026-02-27 18:20 ` [PATCH] tools/sched_ext: fix strtoul() misuse in scx_hotplug_seq() Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2026-02-27 18:43 David Carlier
2026-02-27 19:19 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227181439.10323-1-devnexen@gmail.com \
    --to=devnexen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox