From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E7F3446A6 for ; Fri, 27 Feb 2026 18:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772216085; cv=none; b=G/8kIYcBGkojJNM/QxkuzHCcg5CDhI6m1CYAGQEkhXJNScheHA1O90Ck+pSm2VnTLNvwtfs/LurHbM+qt3tCtywmdU8EZE0NPHY4eytSS3AFI7JUTTht+CXYqjAlk4igBa+cGH1i8cKK37LXYUrkGYZ1xVboN6yfGpVD3QUfmic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772216085; c=relaxed/simple; bh=OaYeBT4t+0qq0Ie6qDBBTKP+CrJQh/o+eTrVvtb6nuk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hwGtoHsKAFBafbD5udblLrAbo7MywCnKbVfD13zTzIoIql+VdTRD3VdSe+2tI1AKeCbG1fHyu6Ecls4KJRAihOkVXLwBcVWJ/+EERvh4BO5AfAgefAtZnIBE5jjug1KVGwvaa/n3LY88wKi563/WEaWK/LcDhUN9Zy33me9qMZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZHiVLsE1; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZHiVLsE1" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43988056dc3so2339527f8f.3 for ; Fri, 27 Feb 2026 10:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772216083; x=1772820883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k1n1gBFUSHtmzz7xydAi+J2pkQpl7UHi0GkLzHepjic=; b=ZHiVLsE1a2n1W5DDe+XMQ0hmdZ1qvazaFSlgw/ML09bJYviwD3hS/ttUdNVYCi5/VD 9Lkg1kHTahv++I3lAgx0h4bqiL75ONI+fvP8yXIQMrRmIEa2vEOc0CD9MIczGfFk1bn2 q9i2cGXzy+0v4THEjRSMDdkX1kobhqya4DQaGA3isee32PmIrfOIqVeg+YY8uIxENtSD SJmOQdV3SpKPxGn9kN2OA86t2moc2iS6k6fbiHX2mJV3qtkr2KgfSfubP2+5YZmgR1nc lvmsB+7Y93Mhjik0Z5EqUme9VOgniERRQlzGsvRqoWL50DVhx2UrctN8b09RBmgghulG 7ahQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772216083; x=1772820883; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k1n1gBFUSHtmzz7xydAi+J2pkQpl7UHi0GkLzHepjic=; b=B4BVZHNVjP14Mr5NbOTKFIO4t2tI4vttm4pljdaKbZSQPoOCrHE2mYAJK21vPh3eG7 1+5oBg5raz8XrVgrBIXquWpJmKQAWEVNyB5FMjHy6oicubzHL/kMXI2Tf+wYZPgVl313 dp9LqxsPdZCsejlGruTlN5VMAvcnaIV/CCcoaV+rUNNkT5oP0iliVS88/3qqtlYIeU7O SyW8XkNnVR/waOBRRbA4MU4GboY3ZjCEns9KIpk1pOdtOESD1MuMca2zk9SyKBa6Cf2k iwdd7G+NmFcBojzs1iahOD+HP5z3axo7tkgMihoqOzOmoWESjRufRKuvsxl0+BTliFow SBhw== X-Gm-Message-State: AOJu0YxlGA3jugwG9DI5XCqHKlQpHgJXjQHDhTvV5xnkjWAhIHptjCqW esq60Z3GiMKrt/pth6ZdW5DcmiKpwBvDUkxsqfr7JpTZWMBkjyULRS8pi67g2ezd X-Gm-Gg: ATEYQzzT+RAQs71KDrKw+gzvdT8S+DY1KyYHi8BPvkgf14ZZ6L4V235ERYzoNpqDJ0F 48n33Vw20QaZotUuLuEegJCFUZkpaVa3nFjv8m63AqrLu0Nm+PuonHrqhTe5fvKHsGrhJvaGmbS xcRVYXP6snFYXa3uUSeybCdIt9K/gMC33befwW9IwkaMk02OH9192W00csYen3ekRgC7jPEWOLh 3Tn5FqUpU9hW+5yq7KHtyBFy+o28v1DZ18FAxgmcDF9I5xTZtcvE1XUJBptRYzpfzrAN+E9Hg8a gHVVQg1HuOkpHh66+ukV+gDQyiD2PBbkMsObwovo6vE4gRp3O0clDF+FdSCl+OQf3fg4OP6LNt4 g0mLp64gZekxFwlyPknYVcBN5nFkxuWD+hqhm1YTbhCBVf9d9zCOnbXpx1ab37BnUlQ0UZBTbEo oQgFJPR9zlG/aFU0EoLjsXj7pioWuEKCmYt/QevBabJbEB/xl5n5quVP/TVJLkK1yB+XbV3+rzl mJEvBzm/bJSrVkovD7d X-Received: by 2002:a05:6000:240d:b0:436:3536:f698 with SMTP id ffacd0b85a97d-4399de3e4d4mr6460456f8f.30.1772216082572; Fri, 27 Feb 2026 10:14:42 -0800 (PST) Received: from rozandragon.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c75b327sm9212860f8f.20.2026.02.27.10.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 10:14:42 -0800 (PST) From: David Carlier To: Tejun Heo , David Vernet Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] tools/sched_ext: fix strtoul() misuse in scx_hotplug_seq() Date: Fri, 27 Feb 2026 18:14:39 +0000 Message-ID: <20260227181439.10323-1-devnexen@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit scx_hotplug_seq() uses strtoul() to parse the hotplug sequence number but checks the result with val < 0. Since strtoul() returns an unsigned long, it never produces a negative value, making the validation dead code. Switch to strtol() so the negative check is meaningful and fix the format specifier from %lu to %ld to match the long type of val. Signed-off-by: David Carlier --- tools/sched_ext/include/scx/compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/sched_ext/include/scx/compat.h b/tools/sched_ext/include/scx/compat.h index 8b4897fc8b99..1518d05d3e21 100644 --- a/tools/sched_ext/include/scx/compat.h +++ b/tools/sched_ext/include/scx/compat.h @@ -137,8 +137,8 @@ static inline long scx_hotplug_seq(void) buf[len] = 0; close(fd); - val = strtoul(buf, NULL, 10); - SCX_BUG_ON(val < 0, "invalid num hotplug events: %lu", val); + val = strtol(buf, NULL, 10); + SCX_BUG_ON(val < 0, "invalid num hotplug events: %ld", val); return val; } -- 2.51.0