From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A2D1C2AA for ; Fri, 27 Feb 2026 23:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772233263; cv=none; b=ogRLjnPOIj+FVChTNckRzCpLS4jkC8XU0BlnavjGAzjwJFqMcN7qk1L0QcQzXhT0TSvBylyGwxT2aUT2GHn9pBltPyQy0MkWroBSBqXQtNWBtRj/vLboFZwPTve0N/c/xlofKBq5Wr8j62ZJUqOL0b+M7Oi1kTgkKqiYFviJGw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772233263; c=relaxed/simple; bh=jikt4BO5bKr68du97aEy1rmSSVZVowMT1HhoobeHQAw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=E9I3B7AKYBSNyYku2evolXIo2qtxICN6rq4MA+B2nlKM6HAjfx1IE/Tr2+Eyjhq8AZHCh0O2XDdNmEXc5jZAVTUaRSfOP8qKqtwZz3jDv866U/v+cejZc1bmiOT1tw9wbUO7Ah6Q5ChjvYGJltV4s4U1bN2htq+OyrwSdYsg3+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=h00peL+A; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="h00peL+A" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772233250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f83mZvouigfOnm3JS7ZtfSKIhAmQ+Bxe6S0lXNepeKM=; b=h00peL+AccAhBGNphQwdzqANq+R2EFOQu50iORciSlJ4eDZBommnIssqbmu99doaXHiRsp pSW+pUUYlCZ1fTb9VLYdqIrDnDdbtqI8JRraRLhlRBGOXKfhm+46IkfSTFV7U2V2E/i7eE BEvZ6M5Pga8na4nPvKEZBBnpgQBNIxQ= From: Thorsten Blum To: Andrew Morton , Baoquan He , Vivek Goyal , Dave Young , Coiby Xu Cc: Thorsten Blum , stable@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] crash_dump: Don't log dm-crypt key bytes in read_key_from_user_keying Date: Sat, 28 Feb 2026 00:00:09 +0100 Message-ID: <20260227230008.858641-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT When debug logging is enabled, read_key_from_user_keying() logs the first 8 bytes of the key payload and partially exposes the dm-crypt key. Stop logging any key bytes. Fixes: 479e58549b0f ("crash_dump: store dm crypt keys in kdump reserved memory") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum --- kernel/crash_dump_dm_crypt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c index 27a144920562..5ce958d069dd 100644 --- a/kernel/crash_dump_dm_crypt.c +++ b/kernel/crash_dump_dm_crypt.c @@ -168,8 +168,8 @@ static int read_key_from_user_keying(struct dm_crypt_key *dm_key) memcpy(dm_key->data, ukp->data, ukp->datalen); dm_key->key_size = ukp->datalen; - kexec_dprintk("Get dm crypt key (size=%u) %s: %8ph\n", dm_key->key_size, - dm_key->key_desc, dm_key->data); + kexec_dprintk("Get dm crypt key (size=%u) %s\n", dm_key->key_size, + dm_key->key_desc); out: up_read(&key->sem); -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4