public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [libertas?] INFO: task hung in lbs_remove_card
Date: Sat, 28 Feb 2026 11:35:20 +0800	[thread overview]
Message-ID: <20260228033522.584-1-hdanton@sina.com> (raw)
In-Reply-To: <69a17e72.050a0220.305b49.00de.GAE@google.com>

> Date: Fri, 27 Feb 2026 03:22:26 -0800	[thread overview]
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    bb375c251ab4 dt-bindings: usb: st,st-ohci-300x: convert to..
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> console output: https://syzkaller.appspot.com/x/log.txt?x=1141755a580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=f1500201919951cc
> dashboard link: https://syzkaller.appspot.com/bug?extid=c99d17aa44dbdba16ad2
> compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1191555a580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=114a15c6580000

#syz test

--- x/drivers/net/wireless/marvell/libertas/firmware.c
+++ y/drivers/net/wireless/marvell/libertas/firmware.c
@@ -111,9 +111,20 @@ next:
 	do_load_firmware(priv, iter->helper, helper_firmware_cb);
 }
 
+static bool lbs_check_fw_loaded(struct lbs_private *priv)
+{
+	unsigned long flags;
+	bool rc;
+
+	spin_lock_irqsave(&priv->driver_lock, flags);
+	rc = priv->fw_callback == NULL;
+	spin_unlock_irqrestore(&priv->driver_lock, flags);
+	return rc;
+}
+
 void lbs_wait_for_firmware_load(struct lbs_private *priv)
 {
-	wait_event(priv->fw_waitq, priv->fw_callback == NULL);
+	wait_event(priv->fw_waitq, true == lbs_check_fw_loaded(priv));
 }
 
 /**
--

  reply	other threads:[~2026-02-28  3:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14  9:42 [syzbot] [libertas?] INFO: task hung in lbs_remove_card syzbot
2026-02-27 11:22 ` syzbot
2026-02-28  3:35   ` Hillf Danton [this message]
2026-02-28  5:14     ` syzbot
2026-04-08 11:46 ` Forwarded: [PATCH 1/1] assert that the firmware has not been loaded before waiting for load completion syzbot
2026-04-08 12:11 ` Forwarded: [PATCH 1/1] add lock to wait queue syzbot
2026-04-08 12:20 ` syzbot
2026-04-08 13:10 ` syzbot
2026-04-10 15:38 ` Forwarded: [PATCH 1/1] move callback syzbot
2026-04-10 20:56 ` Forwarded: [PATCH 1/1] add wake_up call inside if_usb_disconnect syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228033522.584-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox