From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB105285C89 for ; Sat, 28 Feb 2026 08:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772268722; cv=none; b=g/nHD+fJaLuPw2roqIeebm0B6uXHV9wRmH3OSJ4zt0Oti+BsyCUpOFra+xq76jj+KegL6TARaPkdUZ1EUM4//1uBzpfxn5QDCLV3eAadmxPZJgeZG8tpcrxhuLSF0ZH+mIpwZN3n0wZSf8qEEVVl7gCZ/C42P6JL1ck3HKCFrGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772268722; c=relaxed/simple; bh=0V5N9hAOXc4GdEFJNgDL76x7IkbslKicnWpWUsbSyJw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N+8HJtNELXrv76kfXUT2IEhzHW+AQtAOQHU52HfkLuU3hgrOylS3G1UhXEZv9GVzFsZe9WDqoQKCKdr3t58zTe1wWNlMLlRdFvrBS3liLfO2b4ZlE9Ls9ip1936L61rmu+e2A2xgDZqc0QQNibKJyv3z5gKcDRLNa7HMIce8US8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=o4qVS3rX; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="o4qVS3rX" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772268718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YhcUvXElMmMtAuDvouG9Fdh+PuKMUo/ONV8mgk2gKU0=; b=o4qVS3rXfiJB+DCIHacwR6HDakO53aBvv5Ob+gllXFdiEIVPadxgeIWfnWB9ar3dmLVetF DH1jMGn3Ofefa9Y6Ap/KtF7QdrbW+mm0j2k4w8vRYRdyyI3MyyGZqIVpx+P5/q1LQUunYr t4fRk7LutimAK+sqa3iXoKshKMJRxH0= From: Thorsten Blum To: Andrew Morton , Baoquan He , Vivek Goyal , Dave Young Cc: Thorsten Blum , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] crash_dump: Remove redundant less-than-zero check Date: Sat, 28 Feb 2026 09:51:36 +0100 Message-ID: <20260228085136.861971-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 'key_count' is an 'unsigned int' and cannot be less than zero. Remove the redundant condition. Signed-off-by: Thorsten Blum --- kernel/crash_dump_dm_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c index 1f4067fbdb94..27a144920562 100644 --- a/kernel/crash_dump_dm_crypt.c +++ b/kernel/crash_dump_dm_crypt.c @@ -115,7 +115,7 @@ static int restore_dm_crypt_keys_to_thread_keyring(void) addr = dm_crypt_keys_addr; dm_crypt_keys_read((char *)&key_count, sizeof(key_count), &addr); - if (key_count < 0 || key_count > KEY_NUM_MAX) { + if (key_count > KEY_NUM_MAX) { kexec_dprintk("Failed to read the number of dm-crypt keys\n"); return -1; } -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4