From: Jakub Kicinski <kuba@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Yao Zi <me@ziyao.cc>, Yanteng Si <siyanteng@cqsoftware.com.cn>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Shangjuan Wei <weishangjuan@eswincomputing.com>,
Chen-Yu Tsai <wens@kernel.org>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, Yixun Lan <dlan@gentoo.org>,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC
Date: Sat, 28 Feb 2026 13:18:45 -0800 [thread overview]
Message-ID: <20260228131845.70421792@kernel.org> (raw)
In-Reply-To: <20260227075718.2243818-4-inochiama@gmail.com>
On Fri, 27 Feb 2026 15:57:17 +0800 Inochi Amaoto wrote:
> The ethernet controller on Spacemit K3 SoC is Synopsys DesignWare
> MAC (version 5.40a), with the following special points:
> 1. The rate of the tx clock line is auto changed when the mac speed
> rate is changed, and no need for changing the input tx clock.
> 2. This controller require a extra syscon device to configure the
> interface type, enable wake up interrupt and delay configuration
> if needed.
checkpatch says:
ERROR: "foo* bar" should be "foo *bar"
#110: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:45:
+static int spacemit_dwmac_set_delay(struct spacmit_dwmac* dwmac,
ERROR: "foo* bar" should be "foo *bar"
#148: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:83:
+static int spacemit_dwmac_fix_delay(struct spacmit_dwmac* dwmac,
WARNING: line length of 99 exceeds 80 columns
#243: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:178:
+ apmu = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node, "spacemit,apmu", 2, offset);
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-28 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:57 [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-02-28 21:18 ` Jakub Kicinski [this message]
2026-03-03 1:07 ` Inochi Amaoto
2026-03-02 13:08 ` [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 Emil Renner Berthing
2026-03-03 1:03 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228131845.70421792@kernel.org \
--to=kuba@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=looong.bin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peppe.cavallaro@st.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quentin.schulz@cherry.de \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=siyanteng@cqsoftware.com.cn \
--cc=spacemit@lists.linux.dev \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox