[PATCH] staging: axis-fifo: remove redundant goto end

[PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

Signed-off-by: Josh Law <objecting@objecting.org>
---
 drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index aac2c58ef9b3..d83a0fd5b231 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
 				   &value);
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
-		goto end;
+		return ret;
 	} else if (value != 32) {
 		dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
 	ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width",
 				   &value);
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,axi-str-txd-tdata-width property\n");
-		goto end;
+		return ret;
 	} else if (value != 32) {
 		dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
 	ret = of_property_read_u32(node, "xlnx,rx-fifo-depth",
@@ -418,7 +418,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
 	ret = of_property_read_u32(node, "xlnx,tx-fifo-depth",
@@ -426,7 +426,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
 	ret = of_property_read_u32(node, "xlnx,use-rx-data",
@@ -434,7 +434,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
 	ret = of_property_read_u32(node, "xlnx,use-tx-data",
@@ -442,10 +442,9 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
 	if (ret) {
 		dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n");
 		ret = -EIO;
-		goto end;
+		return ret;
 	}
 
-end:
 	return ret;
 }
 
-- 
2.43.0

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Dan Carpenter]

On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@objecting.org>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aac2c58ef9b3..d83a0fd5b231 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
>  				   &value);
>  	if (ret) {
>  		dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
> -		goto end;
> +		return ret;
>  	} else if (value != 32) {
>  		dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
>  		ret = -EIO;
> -		goto end;
> +		return ret;

Just return -EIO.

regards,
dan carpenter

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Greg Kroah-Hartman]

On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@objecting.org>

No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(

thanks,

greg k-h

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:

> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
>> Signed-off-by: Josh Law <objecting@objecting.org>
>
> No changelog and your From: line does not match your signed-off-by:
> line, as others have pointed out :(
>
> thanks,
>
> greg k-h

I think I made V2s.

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:

> 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>
>> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
>>> Signed-off-by: Josh Law <objecting@objecting.org>
>>
>> No changelog and your From: line does not match your signed-off-by:
>> line, as others have pointed out :(
>>
>> thanks,
>>
>> greg k-h
>
> I think I made V2s.

Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Greg Kroah-Hartman]

On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
> 9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:
> 
> > 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> >
> >> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> >>> Signed-off-by: Josh Law <objecting@objecting.org>
> >>
> >> No changelog and your From: line does not match your signed-off-by:
> >> line, as others have pointed out :(
> >>
> >> thanks,
> >>
> >> greg k-h
> >
> > I think I made V2s.
> 
> Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you

I have processed all pending staging patches now.

thanks,

greg k-h

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:

> On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
>> 9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:
>>
>>> 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>>
>>>> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
>>>>> Signed-off-by: Josh Law <objecting@objecting.org>
>>>>
>>>> No changelog and your From: line does not match your signed-off-by:
>>>> line, as others have pointed out :(
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> I think I made V2s.
>>
>> Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
>
> I have processed all pending staging patches now.
>
> thanks,
>
> greg k-h

You've NAKed all 10 of my patches....?

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Greg Kroah-Hartman]

On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> 
> > On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
> >> 9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:
> >>
> >>> 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> >>>
> >>>> On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> >>>>> Signed-off-by: Josh Law <objecting@objecting.org>
> >>>>
> >>>> No changelog and your From: line does not match your signed-off-by:
> >>>> line, as others have pointed out :(
> >>>>
> >>>> thanks,
> >>>>
> >>>> greg k-h
> >>>
> >>> I think I made V2s.
> >>
> >> Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
> >
> > I have processed all pending staging patches now.
> >
> > thanks,
> >
> > greg k-h
> 
> You've NAKed all 10 of my patches....?

You have had review comments on all patches sent that I can see, did I
miss any?

thanks,

greg k-h

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 17:02:10 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:

> On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
>> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>
>>> On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
>>>> 9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:
>>>>
>>>>> 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>>>>
>>>>>> …
>>>>>
>>>>> I think I made V2s.
>>>>
>>>> Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
>>>
>>> I have processed all pending staging patches now.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> You've NAKed all 10 of my patches....?
>
> You have had review comments on all patches sent that I can see, did I
> miss any?
>
> thanks,
>
> greg k-h

You missed about 10 of my V2s

V/R

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Greg Kroah-Hartman]

On Mon, Mar 09, 2026 at 05:04:24PM +0000, Josh Law wrote:
> 9 Mar 2026 17:02:10 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> 
> > On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
> >> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> >>
> >>> On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
> >>>> 9 Mar 2026 16:12:17 Josh Law <hlcj1234567@gmail.com>:
> >>>>
> >>>>> 9 Mar 2026 16:09:27 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> >>>>>
> >>>>>> …
> >>>>>
> >>>>> I think I made V2s.
> >>>>
> >>>> Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
> >>>
> >>> I have processed all pending staging patches now.
> >>>
> >>> thanks,
> >>>
> >>> greg k-h
> >>
> >> You've NAKed all 10 of my patches....?
> >
> > You have had review comments on all patches sent that I can see, did I
> > miss any?
> >
> > thanks,
> >
> > greg k-h
> 
> You missed about 10 of my V2s

What is the lore.kernel.org link of the patches I missed?

I see Dan's response to your v2 series of 10 patches, which I agree
with, you need to address that before I can look at that again.  Please
don't ignore his comments.

thanks,

greg k-h

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 17:06:48 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:

> On Mon, Mar 09, 2026 at 05:04:24PM +0000, Josh Law wrote:
>> 9 Mar 2026 17:02:10 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>
>>> On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
>>>> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>>>
>>>>> On Mon, Mar 09, 2026 at 04:14:47PM +0000, Josh Law wrote:
>>>>>> …
>>>>>
>>>>> I have processed all pending staging patches now.
>>>>>
>>>>> thanks,
>>>>>
>>>>> greg k-h
>>>>
>>>> You've NAKed all 10 of my patches....?
>>>
>>> You have had review comments on all patches sent that I can see, did I
>>> miss any?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> You missed about 10 of my V2s
>
> What is the lore.kernel.org link of the patches I missed?
>
> I see Dan's response to your v2 series of 10 patches, which I agree
> with, you need to address that before I can look at that again.  Please
> don't ignore his comments.
>
> thanks,
>
> greg k-h

https://lore.kernel.org/all/20260301214815.2628942-1-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-2-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-3-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-4-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-5-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-6-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-7-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-8-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-9-objecting@objecting.org/
https://lore.kernel.org/all/20260301214815.2628942-10-objecting@objecting.org/


V/R



Also, I am responding to Dan's comments, but I am focusing on lib/ at the moment, since I'm a reviewer, and I've had more time to fix lib/


Later, the patches that Dan NAKed, I will go ahead and fix them for you

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 17:09:53 Josh Law <hlcj1234567@gmail.com>:

> 9 Mar 2026 17:06:48 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>
>> On Mon, Mar 09, 2026 at 05:04:24PM +0000, Josh Law wrote:
>>> 9 Mar 2026 17:02:10 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>>
>>>> On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
>>>>> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>>>>>
>>>>>> …
>>>>>
>>>>> You've NAKed all 10 of my patches....?
>>>>
>>>> You have had review comments on all patches sent that I can see, did I
>>>> miss any?
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> You missed about 10 of my V2s
>>
>> What is the lore.kernel.org link of the patches I missed?
>>
>> I see Dan's response to your v2 series of 10 patches, which I agree
>> with, you need to address that before I can look at that again.  Please
>> don't ignore his comments.
>>
>> thanks,
>>
>> greg k-h
>
> https://lore.kernel.org/all/20260301214815.2628942-1-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-2-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-3-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-4-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-5-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-6-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-7-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-8-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-9-objecting@objecting.org/
> https://lore.kernel.org/all/20260301214815.2628942-10-objecting@objecting.org/
>
>
> V/R
>
>
>
> Also, I am responding to Dan's comments, but I am focusing on lib/ at the moment, since I'm a reviewer, and I've had more time to fix lib/
>
>
> Later, the patches that Dan NAKed, I will go ahead and fix them for you

If it's convenient for you you can ignore one and two since they have no descriptions, patch 5 is worth looking at maybe.

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Dan Carpenter]

On Mon, Mar 09, 2026 at 05:22:19PM +0000, Josh Law wrote:
> 
> If it's convenient for you you can ignore one and two since they have
> no descriptions, patch 5 is worth looking at maybe.

I was predicting that patch 5 wouldn't make a measurable difference but
I didn't know you owned the hardware.  Could you try measure it?

regards,
dan carpenter

Re: [PATCH] staging: axis-fifo: remove redundant goto end

[Josh Law]

9 Mar 2026 22:00:17 Dan Carpenter <dan.carpenter@linaro.org>:

> On Mon, Mar 09, 2026 at 05:22:19PM +0000, Josh Law wrote:
>>
>> If it's convenient for you you can ignore one and two since they have
>> no descriptions, patch 5 is worth looking at maybe.
>
> I was predicting that patch 5 wouldn't make a measurable difference but
> I didn't know you owned the hardware.  Could you try measure it?
>
> regards,
> dan carpenter

LMAO of course I own axis-fifo, that's why I'm doing it.


It just makes code run better to be honest, unclutters it, hopefully moves it out of staging (wink)



Only one or two of my changes are for performance.....

I've measured them in another thread