From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 342014A3C for ; Sun, 1 Mar 2026 00:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326222; cv=none; b=ttuJTeTGbymZyuHRz63urWqqpTmx2yqoayDsvOb/Ppu2v7QoJ1fa0MmjLZ7C7uVj3Q2zIsfSHRynCG69arvukz07aCYNu+eZCEE1dErAMHUito3YVaCtro93I9226ZZNyQQTKsG9R5fsDRP2NMtTFUmrV/lTdlFeix+xHHju74I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326222; c=relaxed/simple; bh=cc0tZZyDVOuJbJmB3ORVkmAH9NghVsqjAK7zxLWUhXs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mWXhvaCLu+q1yo3w+k0gLHXTY2FbIUcPk4ES/5KiUiunh8qKBGzDg7MpSm84VXgOzwrD/3brgpivWD736IVz7jNL/OFt5cUZnLm8lXhBfoG7330Ck7+ocszzIM8KbxgiQTV0USfiGqP/NW+FccMuSUeAKs2Wc5g2VtOvSD2oWUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mqPn9+sH; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mqPn9+sH" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-899ed41208fso7355696d6.1 for ; Sat, 28 Feb 2026 16:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772326220; x=1772931020; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wzoDSGtih/Mlt9ARvVBqZXwsc/ALwBNBaRQVeYKMnhs=; b=mqPn9+sHaHC5zaVVKiKty+RQGEup6+RnTnvWprl5bCyicAHkJ66m5pRZte9pLjeynQ m3UX9CfVdGglgNXCDGE/wInDan1mt+D4Nn0Pet7MWB09abaDgO3wIzauUL25pgxOoMDK Tc1HNuq2DYjMQD7+IFChcgBi8IFsN5cAUDP+RxKDEW1/DBraLYckcBHT4vX5wvbJODAy jCP3BxRjKQymT2586msqljvGiuWjAy9ZQ9Aa3UJPWXsyOvHbRTBFao5C2pTne0S5a1XG sdzGouGEPB/nKKHqlNwR4iIh5sGVkUDeT35QR2JSOvm5WGN5Xe9Y6v57SZRF7kt71o8D L7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772326220; x=1772931020; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wzoDSGtih/Mlt9ARvVBqZXwsc/ALwBNBaRQVeYKMnhs=; b=ITWOOI/tFvJSxp6QTk0Th7TVKiJlujEAXgeOLVpFURU2FEeQXWELtRZjAgWiqtkH49 z+8rmHdxQTdS5h7uGuAsuKCuU02M4t0BCIiwzYnAhZJWzA2+lyvakQJHv/AFmGlGpEcK 8AsmxbTCKUVLPOMvC6UWc5yMzLGlYlow3mJvNem/RENZZXjqSVOVhMGGh4FeaVq0eMM5 GkmT9nHQ0nX/awBcpItRa4kHln6SSr01JUuu7q5dX+1gio+RmehTtLS3Xq0J8KoO7EgA oIMkR6awuWps2HrJESQk8IDXtzRPjICKEBpyZQSSDGSC4iFuMzXytK5DPJOHFDSpePzA L4xg== X-Forwarded-Encrypted: i=1; AJvYcCXX3MqtcQArFIOyabMqau81cjWznSHdPiWqNxzlhWTLCQzn71XdAlF+5NfQBS8Ng/qGsc6a6762Hpu9sD4=@vger.kernel.org X-Gm-Message-State: AOJu0YxKCZKOHzGa/KAqY+K0QJsOEoZ98RFJg1sNTVZd5eDA+zOU8oi3 bu8EOiX+sKMci2Mp7DBAoYbWJtUS4UkZETCH/QGWHRgd613bM829k06QVRh97ous X-Gm-Gg: ATEYQzyLLdmZ/rJckol/cyZdxD+vDRotBy/lDou7V5SVDi3RnnejzvDos0jZK1+a86w LgIRIeGGranuUs2aG205CymGanhwU2SeYPaSzClXFmn6Xy5DlCJd6Eq5DiEWe8okJUyKXk9LXYR 7m4YywjnM25zFvJDAn3Tmf8h36hSYluyZkabVq8zfxKYWKl5kqHRI6B57Lyb9mfnZ+Unu1dA4BE 3ojMHGHf0SZwNs6NRi19WAUp+Lc4nlZ+OzKynCnUKSDzbgnI3hu0HZTmjwF7EI382rSNntIHonE s1g6B74eEhbcXzSPeQ/MSAwpEt6KsPRjWZtLtee9/qJYS2/SbxAVYFmy82GYKx2jYGk9ueJveBY jVNOVqfGmQrISadaiM4THQNDdZhrqZVaboHp/Fg1uOSoHvCXqFLNiiU3uTmOeVBflAakl4tmnmU /eAlQBwVM6U0i5K3wkKU33c5FWvlxNWonE7dxvckfJiOFwXj247rgLGWpBekVzKObIjztn1a1WZ L0SvbC+E9O1V0A= X-Received: by 2002:a05:620a:7108:b0:89f:8bb8:c103 with SMTP id af79cd13be357-8cbc8df0b7fmr1048663185a.49.1772326220166; Sat, 28 Feb 2026 16:50:20 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899ef69b07dsm9008586d6.42.2026.02.28.16.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 16:50:19 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH] staging: axis-fifo: remove redundant goto end Date: Sun, 1 Mar 2026 00:50:19 +0000 Message-ID: <20260301005019.2510157-1-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index aac2c58ef9b3..d83a0fd5b231 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) &value); if (ret) { dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n"); - goto end; + return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width", &value); if (ret) { dev_err(fifo->dt_device, "missing xlnx,axi-str-txd-tdata-width property\n"); - goto end; + return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", @@ -418,7 +418,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", @@ -426,7 +426,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,use-rx-data", @@ -434,7 +434,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,use-tx-data", @@ -442,10 +442,9 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n"); ret = -EIO; - goto end; + return ret; } -end: return ret; } -- 2.43.0