From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9E222DB7AB for ; Sun, 1 Mar 2026 12:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772368562; cv=none; b=i6oSbFleoESJYmvTGcq5Sgb+SEbRHqQdnCYrXYn+MKmAlUTDQn1LOOOc18cAnxcXbsB3WLqj1HJ0j0gwReP7nVSJROt/81/bUQ6Lwg1gG6udEsCbejfmITU8R+Q/Km6jn6tRocX/UHEI/UkfbbZaZz8cW8kWbImfp3uKq1tTVTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772368562; c=relaxed/simple; bh=YBF9BYKbYIlSAGru0TQQbtbsevPnAE/QxOrhYk4Ab6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KeCrEd0ntLLnLdYt78fnlGGLEXVLrY0PrDsbZaZfCkFC1oqweoNM8uhJpEdKsTF7caiDH+LHp6MdqzEoEpdjePzhZG9B4HX5kzlhn9epkoEek+P/blFmst/fMnqaQoKxTsARot0FaJOf/ZVeA7pj2dp6nb3gbxg8GWOOczU21JQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R2AIBgfn; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R2AIBgfn" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1275750cfc7so6464202c88.0 for ; Sun, 01 Mar 2026 04:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772368561; x=1772973361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BzFXSy0QviyDiMF/kzMrH03+sliS+deFE1g+XpxSQKg=; b=R2AIBgfnnUn4JPXpocVWSauoMZPXuGaD02TdexBeWk2x0wbsKzpsYPstxEOPCGuMgc T+wa8sihst1FEtvkmIuWr85qqAwlQqsjtXAE5iSYIz5rt/91lBIXx9t2VE/5l9mxDkAh l9Cg76CvGItfKrJUy+GXoLkwg9fGdjukoUhfs677XP25diyXsJW17vaQEd8mvZkNtcr8 OL/+/wnP3qnM/sN24nKPsIPpc9YaL7dlnSAzrFoL5SfGlgAOqPNQWQutNv8/DzNymV2K LJZx1FPp1PlbGh+F+oIbRndIC1HZ7eE3JH6Oc++SDb2+WcwJa9oXqZZ/M86HURzRAw9E RQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772368561; x=1772973361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BzFXSy0QviyDiMF/kzMrH03+sliS+deFE1g+XpxSQKg=; b=jxHWgT97SnCKSOaIJ/rsSAybppaNHbR2G9AMPV2uyR0nhTPowqoglYTvaVWUakp9f2 Bly/nril24QdRwYwQsUizkWTjhXWgU2psrtuztf0mnCo4A5TuBcXPXqNsBayZvBC0EhH NAEAPqtB/l1ToNxp/m6W8EpfgD/Dp11RX29RGAQHOZzbxaQMhk/WZY1R6Si9ulSOfrha qnezKb7ij2B9xDTUsOFGz9l0SOABvhYKm4j7eBIkzWs9GRws7eM4sZd8ZyN2rYU3Vjzh yCq+OHB6DqTIlIbIFeWARK5bK9w89CytOhEvH85iIg0zl6q1gDLXEj1fswuPsR3nTqRA E38Q== X-Forwarded-Encrypted: i=1; AJvYcCUCQMoClQ0x16RuMHTB0pgYnL5emtm9jplofGqY/DFXKivF5hCPvFFSprNOV2IIImKE4cQJp+e6DtpGoHg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/I8lW2ArBdg/npgyJHzxlbGaXJuIEO0ElOz4EmoquDIW5Ngb6 Drou8dPejcpCJMEMpyYM9wmBRFBKbpbA5OIwmeq85sPpYOw3pfeW/Lqh X-Gm-Gg: ATEYQzzue/ymg2B3Uu7QflzyPPgMIryXjFSihHZupq+TdVE+/PB1ppIg48Mv+CTSefx 5UvAXlxFVux5qSlKPPckc3GJGhGcPq8ws9oDk6NNO1rR0NANCnzitIo+2P9ZUkuNonhQ7Yld7tU 4tc7BfFFtYKWfZOlrOONZgRRDcTNe0AEsxLoITixXhDkF5nKHvxyZOPplARjZiA9FW3ZxFvk9nD BG1e03H9NzgGQ35HmWQampq9mBT9DS+IU4KIGYtTZZEnsPtsXOsVlOQaxTUJTAuBjpa0jiViUNQ JNouxM5WGy7yWwA3qBSHH8iUvNd7lk3y2KT0H2KfvVz9mr6peS2HuNN5jJ3WaJ8yiK9e4pSyYa+ uXHZ2DCS5qrJal0C3vLbRKtU/1EDgHRwCqVpOOfw3YYykb5jPs9YD89rllY1Z009O199m7eqkae k6z0VtWO3FSCk+Xuek1pbaWw== X-Received: by 2002:a05:7022:609e:b0:124:9dea:188d with SMTP id a92af1059eb24-1278fcfdcf6mr3544073c88.30.1772368560788; Sun, 01 Mar 2026 04:36:00 -0800 (PST) Received: from fedora ([187.120.159.36]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12789a32633sm11631217c88.9.2026.03.01.04.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 04:36:00 -0800 (PST) From: Guilherme Giacomo Simoes To: trintaeoitogc@gmail.com Cc: agruenba@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] gfs2: do not evict glocks with populated address spaces Date: Sun, 1 Mar 2026 09:35:51 -0300 Message-ID: <20260301123551.138132-1-trintaeoitogc@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203140030.36921-1-trintaeoitogc@gmail.com> References: <20260203140030.36921-1-trintaeoitogc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Guilherme Giacomo Simoes wrotes: > Sorry, yes has two GLOCK_BUG_ON() assertions. I talk about the second > GLOCK_BUG_ON on __gfs2_glock_put(): > `GLOCK_BUG_ON(gl, !mapping_empty(mapping))`. > > NOT ABOUT `GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders));` (the first > GLOCK_BUG_ON()) > > The dump_stack() indicates a memory pressure and the > gfs2_glock_put_eventually() on fs/gfs2/super.c is called. > But when the __gfs2_glock_put() was called, the glock was has a private folios. > I test by this way: > ``` > struct address_space *mapping = ...; > pgoff_t index; > struct folio *folio; > xa_for_each(&mapping->i_pages, index, folio) { > if (folio_test_private(folio)) > pr_err("I have private folios") > } > ``` > > And, I can see the glock is about metadata: > `gl->gl_name.ln_type != LM_TYPE_INODE` > > the truncate_inode_pages_final() failed silently when the folio is private. > > I guess maybe evict metadata (or locked) glock is not a good idea. Andreas, thoughs?