From: Thorsten Blum <thorsten.blum@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] crash_dump: use sysfs_emit in sysfs show functions
Date: Sun, 1 Mar 2026 13:51:07 +0100 [thread overview]
Message-ID: <20260301125106.911980-2-thorsten.blum@linux.dev> (raw)
Replace sprintf() with sysfs_emit() in sysfs show functions.
sysfs_emit() is preferred for formatting sysfs output because it
provides safer bounds checking. No functional changes.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
kernel/crash_dump_dm_crypt.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c
index 1f4067fbdb94..827572aa800b 100644
--- a/kernel/crash_dump_dm_crypt.c
+++ b/kernel/crash_dump_dm_crypt.c
@@ -6,6 +6,7 @@
#include <linux/cc_platform.h>
#include <linux/configfs.h>
#include <linux/module.h>
+#include <linux/sysfs.h>
#define KEY_NUM_MAX 128 /* maximum dm crypt keys */
#define KEY_SIZE_MAX 256 /* maximum dm crypt key size */
@@ -189,7 +190,7 @@ static inline struct config_key *to_config_key(struct config_item *item)
static ssize_t config_key_description_show(struct config_item *item, char *page)
{
- return sprintf(page, "%s\n", to_config_key(item)->description);
+ return sysfs_emit(page, "%s\n", to_config_key(item)->description);
}
static ssize_t config_key_description_store(struct config_item *item,
@@ -265,7 +266,7 @@ static struct config_item *config_keys_make_item(struct config_group *group,
static ssize_t config_keys_count_show(struct config_item *item, char *page)
{
- return sprintf(page, "%d\n", key_count);
+ return sysfs_emit(page, "%d\n", key_count);
}
CONFIGFS_ATTR_RO(config_keys_, count);
@@ -274,7 +275,7 @@ static bool is_dm_key_reused;
static ssize_t config_keys_reuse_show(struct config_item *item, char *page)
{
- return sprintf(page, "%d\n", is_dm_key_reused);
+ return sysfs_emit(page, "%d\n", is_dm_key_reused);
}
static ssize_t config_keys_reuse_store(struct config_item *item,
@@ -321,7 +322,7 @@ static bool restore;
static ssize_t config_keys_restore_show(struct config_item *item, char *page)
{
- return sprintf(page, "%d\n", restore);
+ return sysfs_emit(page, "%d\n", restore);
}
static ssize_t config_keys_restore_store(struct config_item *item,
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
next reply other threads:[~2026-03-01 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 12:51 Thorsten Blum [this message]
2026-03-02 3:22 ` [PATCH] crash_dump: use sysfs_emit in sysfs show functions Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301125106.911980-2-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox