From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref
Date: Sun, 1 Mar 2026 13:41:20 +0000 [thread overview]
Message-ID: <20260301134120.38ae5ae0@jic23-huawei> (raw)
In-Reply-To: <aQCXm_rvwpB6-UUq@smile.fi.intel.com>
On Tue, 28 Oct 2025 12:14:51 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Oct 28, 2025 at 01:41:02PM +0800, Billy Tsai wrote:
> > Ensures the reference voltage bits are cleared in the ADC engine
> > control register before configuring the voltage reference. This
> > avoids potential misconfigurations caused by residual bits.
> >
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---
>
> It's a v2 and here a changelog is missing.
> No need to resend, just reply with a missing piece.
>
Billy. This one is still outstanding.
I was rather expecting a fixes tag as well.
I'm going to mark it as changes requested in patchwork and stop
tracking it. Hence please send a v3 addressing Andy's comment
and either add a fixes tag or say why one isn't appropriate.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-03-01 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 5:41 [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref Billy Tsai
2025-10-28 10:14 ` Andy Shevchenko
2026-03-01 13:41 ` Jonathan Cameron [this message]
2026-03-03 1:45 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301134120.38ae5ae0@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=billy_tsai@aspeedtech.com \
--cc=dlechner@baylibre.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox