From: Josh Law <hlcj1234567@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean
Date: Sun, 1 Mar 2026 15:21:42 +0000 [thread overview]
Message-ID: <20260301152143.2572137-2-objecting@objecting.org> (raw)
In-Reply-To: <20260301152143.2572137-1-objecting@objecting.org>
Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools.
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/glob.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/glob.c b/lib/glob.c
index 902b5037a0a8..afff28285bd4 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *str)
class += 2;
/* Any special action if a > b? */
}
- match |= (a <= c && c <= b);
+ if (a <= c && c <= b)
+ match = true;
} while ((a = *class++) != ']');
if (match == inverted)
--
2.43.0
next prev parent reply other threads:[~2026-03-01 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 15:21 [PATCH 1/2] lib: glob: add explicit include for export.h Josh Law
2026-03-01 15:21 ` Josh Law [this message]
2026-03-01 19:25 ` [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Andrew Morton
2026-03-01 19:40 ` Josh Law
2026-03-01 19:43 ` Andrew Morton
2026-03-01 22:05 ` David Laight
2026-03-02 2:56 ` Kuan-Wei Chiu
2026-03-02 3:02 ` Kuan-Wei Chiu
2026-03-02 7:11 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301152143.2572137-2-objecting@objecting.org \
--to=hlcj1234567@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox