From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA37728C87C for ; Sun, 1 Mar 2026 15:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772378506; cv=none; b=Nv8VQJxSWSHMDXSiAY9zurFHAkIUFELCV90fg+1rCzy/MSD87GWp9jWB14kwKghCJFSS5Ok7Id8flRdwixKbbqid5odZjBOY/o4auOcD1Nh8Fun+aw+muzvB88P6FiG2OZ5uilBAsoNqo+qwRMvWatSD53D7c5pLoRtXCO/jJQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772378506; c=relaxed/simple; bh=RlSQAzozNGr0n4U2O3MmwB7mh3H3RVdAAqqiPIuM0TA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tQCtT6SxHIUj+PxhVVjbo74kQrP23nTmw6JkvGGrCbotdfJcogYkq/cDgUzvdzNs+ujgFFV/Bhx/3kFjsacUwUMXNsufP3WmWl5MW3YBDpNlSDyNG3EAdCIP8bBRO8VVBGpdJ/fCFXSXUzNbCnpbURoajP5voVORGqgvGexRwfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VPNA5Sx2; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VPNA5Sx2" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-899a5db525cso32702076d6.3 for ; Sun, 01 Mar 2026 07:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772378505; x=1772983305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h3DLiYGq783Q8R5Zn2llliW/6hSRrYzp1Hn6tCcOJlM=; b=VPNA5Sx2FbHLayLrFiq8CvuKlz92Cdr6WXrFktpmDf3LSbPnck14wWZGxZlHz2wKgD A95KbVr6pOuXb1OAnzIB5+5mrSR3BxFevDZJagkAbEXaENXtDkTnGLdxhl3moOw4bvw4 QnLNwrI5erX424oTuph0COY5pRl7kKfAQzpg0WDjoaDcUmqOTbvgjnFiJZB1taCgOCCY vzRnWyrUXcRFdQkALybcLG8l6iKmDVYB/hBVj7BGlEZyLrGwvyvQx/DX1LjsupoKSf98 N+WDhwJv+26NnVMQkSNFPjx/uiUWBA9abz12MNLce3Z5KeA58ChgEp4vzch9rEMHtr8b fnBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772378505; x=1772983305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h3DLiYGq783Q8R5Zn2llliW/6hSRrYzp1Hn6tCcOJlM=; b=bf5Xi8ZsDcW4STNTN2htz8EBCUfOFmE3MOqFY8bHMAlXfZyxWAXBuKoVatCCJRdjcE WzLps7wN9cOiBGjPvGPNbvlUC0L+UtpAAHMqgOtlPSkacT+dWTMhLJZnUF1K/XXfsSpF tZnQDVpa7BOV2S3P2YyC25EPWokvWt9fHm21kmNDz1ji0ztrnLQBh1mim6TFkdnTWIx9 SZBorqy2G8kkx6K/Q+y+Tp7ZdhgMiC7KIMm2lNM6zMaE1+AXzfB5qvLIdS4jIFFdmaB9 66DmBNlvJICunMODlEu0ZAZLuGJwL0yReDPtcq4GYW4jNURjkhFZ7qPu7970M7deY0Uo bmFQ== X-Gm-Message-State: AOJu0YwCJ/jm8rI2GTuXhAFbftVIRTFZEbjm55VOyO7hnPREtimJCJb4 SrkmgGt9iMvdG7wKd1kGWUadi7bcQJAoDOeOkXKOM5ADIVbkSbilV1YCkmqTYjZc3YU= X-Gm-Gg: ATEYQzx2jHGXYeA7PG07hkZbWvEJvaVHEdV9NY0Pd8/f4SgeG/sfCa2bubfov++1qhf JnJYwyXOeLMV+bRIsxVHxB2hwxf23kMdD+fkfqpFZd+neaw2pglP2l0AyjPjfZ4rxe3Pmr0R2+7 uLWf/e0Gq2jnBL14S0lfCpsWJfXOnCtVfcv4Z39Z9JqWBtotCiUoz8rbAXE2wAo+RH4S9IRFDMq ltObvU7nYez4uueh7Ps7y1xW6rwHweHk9MXvpeL0lDSanNCQusC6kDqBxsBzzvmiqohHAwl93yr 3d7YhEk3xU/uqvGKr41/g30mS/0beJO8SuGMukK6lUVjLnhKoH3hmro5DaMzA5NvW06bghGvLu8 bUzBel+mvSg0AfxbUqxzfQK6pT4Q//6KcaLmblXEKAjfBUhywFiHDEBb8BtimDQ3fDDzaJYYnvm AAD8iIccMDfyU+6vGenZoHTHcOtusgmsxN/gyfYbj7eqop6IYYdBgYY/3uD7qPC8Dqg8m6rwefl Anc X-Received: by 2002:a05:622a:1212:b0:4ed:b47d:8f68 with SMTP id d75a77b69052e-50752840aa9mr116473521cf.15.1772378504733; Sun, 01 Mar 2026 07:21:44 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899ef69b07dsm21574596d6.42.2026.03.01.07.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 07:21:44 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Date: Sun, 1 Mar 2026 15:21:42 +0000 Message-ID: <20260301152143.2572137-2-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301152143.2572137-1-objecting@objecting.org> References: <20260301152143.2572137-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. Signed-off-by: Josh Law --- lib/glob.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/glob.c b/lib/glob.c index 902b5037a0a8..afff28285bd4 100644 --- a/lib/glob.c +++ b/lib/glob.c @@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *str) class += 2; /* Any special action if a > b? */ } - match |= (a <= c && c <= b); + if (a <= c && c <= b) + match = true; } while ((a = *class++) != ']'); if (match == inverted) -- 2.43.0