From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 534771E7C12 for ; Sun, 1 Mar 2026 16:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772381853; cv=none; b=XtUTloAeQ0AMINBRDw2HJez0RcDw9zh+Fc2nWCLNGgbsIiNIIiCHC3og45w7NxMjxjwdSJdmJDEdEg3fmySt8mZFNME18u6wzV0meiiN4X0tQse9pzmeMSBqPQxwuYETL5DWHMGYYq0Uz+JZGq+co5tvblRZy8PLnB9DhE7Dwd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772381853; c=relaxed/simple; bh=DsCvTnRonbBjO2JlO28mIxQ6YAbIlpWMICrRxDHCp3I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t9z7/PTVk7tHYl+a5JHGmjmiA3DLgOqmon9NA/nkIE3JO6168iLs37B5xSzl7Lp3cqhPBCUSB2yEAg6oCU2Gax7+djj0ngBhrqEFayJHFh01RNe3pA+Bez7OwlH3YinlogdNeaCx2Tebkh+tf9QQi19LY49jjZWhtfkPSfCyzFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nX2bclaf; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nX2bclaf" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c70c112cb61so2155360a12.0 for ; Sun, 01 Mar 2026 08:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772381852; x=1772986652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=nX2bclafZqOMOVtfrKaGWpB+5rIGGpw/NsTGWk/jpJ/Uz2DT1pPIyLd27GmZianEB8 UpqpmsgWkhP9E2eBiq5Nxss5vnTH2MdpTkhRI/YNOWFCGS6/NBKy6dDtliuAhoyOEEjq ksOi21fJB/TiMoKPQxbGmhcG1U4wjh7X8f8qUYpaG604OfaTPrrSVS4IChFzOfn/o9FD 5PQOdyzKBIlj5h0orc7bD/RuB4aocbNEeaRAvByxOajDR5wiUJ53bC3zOOtwDfGcdbDl zd6Q8/nHDBT0KAyqbF+JjernTFheYy7XKIaf9L4uWndsvBsk3F891pOcfZUmMx03gVxn hTWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772381852; x=1772986652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=jZighQZjGpD0B/+jC35FuvWCkT4T+AOEqwZUzDdB6r40Qg/ucF3KzTS3uS9mi7qhec 1LfjRBRuTVRO9WazJR1wQgGkQSOoaDGPrNXDIS/6CwS7vjzvSaV3ZywCLrhw4CRULQS4 Ft3tGBD4gSVCJMwE5zfopBj288aZ5lb7z513yapeHm+skdOYDCN+8xBwkg/n78hiLt0c BgT8Bn4clJe2IAiBBRoKCY91Gn2X7GbrVkFqhhzAKpXW2rnpFd2qya5Q39R/u8Oyuil2 YbVRJL/lrT/3WOsjFDBecjIS5prt4VWon8+S/V2fOWupxEyRq2IXVuub8ZMXgDNNINSZ VZ7Q== X-Forwarded-Encrypted: i=1; AJvYcCXwbEiZZkP+T+yT6xMHv2z8B3hCWde4eAkE84fnYLSwyColttJmiCU06obcip9tt1S6nSWVkb6ZMgNNc0I=@vger.kernel.org X-Gm-Message-State: AOJu0YzVmS/C1kgjbb9v1l+pqLeX6iu2LIg49qWChexXDSm3zpUbR8LQ 6+B1ZU0lQPw3uV0cW5vidB1BAVj4wViFydwswRX8o7McvMl3UH2BOoDm X-Gm-Gg: ATEYQzwjlhfyt9VjhliQss3TuPKLEAddESz0+CJ+9z7iPKL7W4GXdxu8YKeG73yyB9t o8/wSeTlJATA381DqVHMqq6ONxZL9eIpchlrXeLGTxFxIAKdMr5+bE9wr8pmbRUxB0+y5EHw5CK vdtDw3TUpefgCLeBdPYcpgKosIguCT66Xhq+6n4jK2LdBa7Cq2FBio0USwyv7abjerhfHPg1aE9 xN/WP5TIIOWaEFv2nys3V1ryTo6vbZvmzzB5oTme6n3HnxXTuDwYp63vaYNrC6cSYwNPYqZnhHG q91CcRAKW7sceymLVaXhxwMn0LectDyFHFv7rfNjcrCJxD37RFY8xVLLAMpJsH0mVWxNgze8nTj Y2onbNgTbVaJ0pna5TARYqOjfTlMuhvmxrhu/NYfOz7N9Q1gfKWrAZFrQJCZ/rgjsdcfxCQ263c 88kIMNsab7rld6WxkuI13cQlBEMhEbqDP7RpncLG+qRjCOgBfeaqSRgijzThxZed5tV2SR X-Received: by 2002:a05:6a20:7f9f:b0:394:8455:d1a8 with SMTP id adf61e73a8af0-395c39eebb0mr11167907637.13.1772381851706; Sun, 01 Mar 2026 08:17:31 -0800 (PST) Received: from sean-All-Series.. (1-160-230-14.dynamic-ip.hinet.net. [1.160.230.14]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa61fcdesm8651456a12.11.2026.03.01.08.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 08:17:31 -0800 (PST) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v6 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Mon, 2 Mar 2026 00:17:09 +0800 Message-Id: <20260301161709.1365975-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260301161709.1365975-1-seanwascoding@gmail.com> References: <20260301161709.1365975-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Suggested-by: Andrew Lunn Reviewed-by: Andrew Lunn Signed-off-by: Sean Chang --- drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 5bc35f651ebd..79ca19097b2d 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev, int sset) static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp = netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,10 +3157,8 @@ static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i = 0; i < QUEUE_STATS_LEN; i++, p += ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); + for (i = 0; i < QUEUE_STATS_LEN; i++) { + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } } break; -- 2.34.1