From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43E31C8603 for ; Sun, 1 Mar 2026 18:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772389817; cv=none; b=K0laX9+zs4PdT90h01Pbn8djy6GAnCU29Y4UOstnhGSmNPFJUJ8i2vh8rA0uIK9H4WXnQNJAl8IOqQfuYOImt+O1r/+u3qG6ixMQmOXtgqtyMKm8hhr6/pg+2pOq0f069gYwSmfMHEwSydaPO3ttkIlda4w3xb3icW3taLP0GB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772389817; c=relaxed/simple; bh=w8G7N9pTJvaGnGfyVGhVoNj9uue4YHSq9A0ZoPgDmX0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S0B25eKOrjpSUCAC4Oh5em7M3p5CMWFip1dHx1ObF4w8Wnxn4zCb7rjBqFD/Y89LuqFX45BNGCM2jnWpjMjIBvtk2W+SUJZwlca3mRiQgxdnHEljxVni+nbmmi9b1kInpiYGM5XCUrKvEzcphL3gzdoqJU+i1Z7A9pgEDDmLr4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NLzldzRy; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NLzldzRy" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-4377174e1ebso2662991f8f.3 for ; Sun, 01 Mar 2026 10:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772389814; x=1772994614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=IkiRMvK/h6xvnrp8j9UgmFcI/eXABewy0sHwl2euagI=; b=NLzldzRys9YgeygaeSrcl73lGKvcmAiJxp5Kay9pq4X8LlHu/Z+dxcWTVNIHXQRT/b zL/d6H6QNVHn4GFZh1sjaFOaOCvABoTIBxwSYuEocQ/AxgJs9/R/1IraYxLUg2du4f9S LjHC0WtOMraxe9sFYwV+j3Lcj2/1jRuSCysh71SeIA/QGmLELWcvkXySEytByvae3Avb O6Ul9cQk+6OZ+eufSX7kt7geqeZhs4npYnRaldRN4sNpWklbbzMCO/U8ferSZ2gCUbdr NW4ZAPpyt8l0fjyMy3NQ7j0hJA4K8GcyAau9M5qiYsvBxtd4ztcCaM3x5w2Qse5AsmmI Ielg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772389814; x=1772994614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IkiRMvK/h6xvnrp8j9UgmFcI/eXABewy0sHwl2euagI=; b=qDdLPqR56puWHqtI8xsN+KKJ3fG0913FYHa5cQekm0KvkdIIDFsjNi71IBXGQNyJQ7 PjQdwj0y8lQIz/0boiSVX798jyyQ6EM9Zp6eNAJ5Ei9jKNp3KNSr7QPY9MTs6UezjprF QI91bTf5+GVfWLDDDufwnyFWN9LRlZ7imAF+QfcF7X14hCngLGPBnJvb5rFnTqp7YW2W fU02Hd6/ZzLVmVbyr7HBttbEEF5xwYfw/m0kQ4zWwhsb5GPrUcmQgruw6We2gEpeJHFo c1D3sPAr3D9+coGUMYDeGj4QnTKHvk/vNtcfD85QaqS+A5SuGHEEF6hNRhEBT0Nw031x kiag== X-Forwarded-Encrypted: i=1; AJvYcCXTRhSbPuieO4LniJGZPR6uInVfDAueB/+ALTgRdsqhzcPUErLg44z/T068aYQy0jvAtpp1k7FHBTcDbEY=@vger.kernel.org X-Gm-Message-State: AOJu0YzOM97gbn7UZLp9WrR0OYRvKHmBEf6UC+PTuGJeen20iIWioqP3 fFSynQrA1YfjK5l+Oj29O+Rf+oBmuPibh7EWY5ZroWgw9DhafkhQFsie X-Gm-Gg: ATEYQzyq760+8zi/v6m9qE9b3PcOt+XzERoMhDe7oXMqUShEebF1cRl6XsY4YRFghuC P7Ch7aPBZvNOCr/uODKeVQfgsPHaoji/A4LQQpYGxadEMJTa9i90pFcZXKp5Y+5IMGNojaCkevh LLMlR2nL+roWzFk08Z9P5rWH5TgpVbEoNOib9LWPj9GpdqL1Mmqlj52jAxaQq6FLEA07Cplcarr XmrdUfHIH39lqn/jf48yZA2T+SPbWtjUeHb8jTiMe5m9b25qf36juMCKRz0j1pDBXqEeo/5FuTU dVo0K62MCerAScZc2Xsptxr5nID014DHaw5FQXARctvg9+a6zke6exW6ERjAHSWMlVd2hx2eHHp MVeAHMDXuIdytjgR50ywLNly/YG/2qkSAfXsIF/RFIGE2gLFef9J1NplGHZ5wh+jnXzA/WkU7NP 4KB1F7YtXoirQeOSFOgtXH/Pwqi/8G6hnGqlxwWIlIBc0B2BtlPvbaTUNXDGaQJXpY X-Received: by 2002:a05:6000:4205:b0:439:8f9f:4994 with SMTP id ffacd0b85a97d-4399dd70434mr16429584f8f.0.1772389814041; Sun, 01 Mar 2026 10:30:14 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439abdf5430sm11136182f8f.5.2026.03.01.10.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 10:30:13 -0800 (PST) Date: Sun, 1 Mar 2026 18:30:12 +0000 From: David Laight To: Borislav Petkov Cc: Thorsten Blum , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Changyuan Lyu , Alexander Graf , Andrew Morton , "Mike Rapoport (Microsoft)" , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] x86/boot: Replace simple_strtoull in parse_gb_huge_pages Message-ID: <20260301183012.3a12ea7f@pumpkin> In-Reply-To: <20260301104454.GBaaQYpia9Kcul6bbo@fat_crate.local> References: <20260202173223.865709-1-thorsten.blum@linux.dev> <20260301104454.GBaaQYpia9Kcul6bbo@fat_crate.local> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 1 Mar 2026 11:44:54 +0100 Borislav Petkov wrote: > On Mon, Feb 02, 2026 at 06:32:20PM +0100, Thorsten Blum wrote: > > Replace simple_strtoull() with the recommended boot_kstrtoul() for > > parsing the 'hugepages=' boot parameter. Unlike simple_strtoull(), which > > returns an unsigned long long, boot_kstrtoul() converts the string > > directly to an unsigned long and avoids implicit casting. > > "The respective kstrtol(), kstrtoll(), kstrtoul(), and kstrtoull() functions > tend to be the correct replacements, though note that those require the string > to be NUL or newline terminated." > > Where are we making sure of that? > > > Check the return value of boot_kstrtoul() and warn about invalid values. > > > > Signed-off-by: Thorsten Blum > > --- > > arch/x86/boot/compressed/kaslr.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c > > index 3b0948ad449f..e6c44a0d3640 100644 > > --- a/arch/x86/boot/compressed/kaslr.c > > +++ b/arch/x86/boot/compressed/kaslr.c > > @@ -219,7 +219,8 @@ static void parse_gb_huge_pages(char *param, char *val) > > > > if (!strcmp(param, "hugepages") && gbpage_sz) { > > p = val; > > - max_gb_huge_pages = simple_strtoull(p, &p, 0); > > + if (boot_kstrtoul(p, 0, &max_gb_huge_pages)) > > + warn("Failed to parse boot parameter hugepages\n"); > > Make that > > warn("Failed to parse hugepages= boot parameter\n"); > I'd suggest including the 'val' that failed to parse. David