From: Josh Law <hlcj1234567@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: [PATCH] lib/glob: clean up "bool abuse" in pointer arithmetic
Date: Sun, 1 Mar 2026 20:38:45 +0000 [thread overview]
Message-ID: <20260301203845.2617217-1-objecting@objecting.org> (raw)
From: Josh Law <objecting@objecting.org>
Replace the implicit 'bool' to 'int' conversion with an explicit
ternary operator. This makes the pointer arithmetic clearer and
avoids relying on boolean memory representation for logic flow.
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/glob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/glob.c b/lib/glob.c
index 877bdd0884a6..69311568ad3d 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -73,7 +73,7 @@ bool __pure glob_match(char const *pat, char const *str)
if (c == '\0') /* No possible match */
return false;
bool match = false, inverted = (*pat == '!');
- char const *class = pat + inverted;
+ char const *class = inverted ? pat + 1 : pat;
unsigned char a = *class++;
/*
--
2.43.0
reply other threads:[~2026-03-01 20:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301203845.2617217-1-objecting@objecting.org \
--to=hlcj1234567@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox