From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183B22ED848 for ; Sun, 1 Mar 2026 21:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772399261; cv=none; b=Z71C1PhVM4swzKeuHtFv34cZ86VkrHIIHqvEnsZlBp2BfW38y/qHmY8qOgzrOtwjllf8x7Av3tyImJXBopppdM1Rhf9npWVY0XVW8lq3cD5UcQHFhv+ppuwrB94MfLIsiWPB8jPLjG9D93mQIwDsdXGpIXeKWH1ZGu9xRlJu0tU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772399261; c=relaxed/simple; bh=tn7ik9AyBb0NPDqOj5PKOQkDMxeMJ5eXuXxBu+YVLZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qXh1TA0rQZlDgu88PUrj+8ATo2xwMHqJlULgMivE11PYH4oqQKzX+LjCqywra+2sC3Sym3HvgtKW2pfrjEA86Gk0uQyRbiYw9JVIpCmEWDOYJPMh/8TgHnHBaQAM6jExCPuDF0xiEU2CgJ6EpBRaPtqZx5aSyDlNhWJLPQqiznc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cJwuXD4I; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJwuXD4I" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483a2338616so23619095e9.0 for ; Sun, 01 Mar 2026 13:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772399257; x=1773004057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hgyk8pX/VzX0B/Mf+s7nhMSchzyVmAxwHP9JMWom8BM=; b=cJwuXD4IyGpz5kCC0HshUx5ELeyVVZT7uMYbrkOBPtJTlsxYSH3tMF+be5T+tSsmLA wGTIt6TF1YdvM+QfGKfYMnu+WRyP+PXrtd9j4kcSfPDkmDkz63K3QWYyFPuQOtIPdNwk 6k1n6fLrQQ+v2wgiUWkVWFfjZaCZjY25sWIPDiGSJU83rkVO2CucrQSNBHhHCfj1M16c 80WwufzhsrAyxLcyyMlSSg0X7xzK7KqMiBgb7kI/HwyywU6LT0aVnX0WbkFFaBc6h6+T vdManudwOOGU1URUcmXEE1HqBn/v858FFCntLTC2aW8q+ugbkTXQwxCPmxb/AJEcuHxO lePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772399257; x=1773004057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hgyk8pX/VzX0B/Mf+s7nhMSchzyVmAxwHP9JMWom8BM=; b=hUbiHmIDqWRYXcztuSgNa+c2VbXqUndBXEQxLN+bgtHxdjMij19TB2XiATua2RZv2X RyUroGVkGvxnu5bRxpeHPz+nTozF/0OOf2skUYZMrxOXrV44RzdQKCdwTFMKtR5cJIiH +mU3oNFsSTiqPPb+iSvQ6Jq5qlYJbJtgBo8RpkDnXPph6SN3aNSACek813Pqv0aHwzKD jJZk5ektcR9D3rXWonKyTL0WohrIDys0p8QOS91IHivNQ1V28P5k2NSD4cDelsdUn4sY pzc7ffhb2fWjILfAaj9do4qS0dXMqeFzXUX/L1xVRixMZbPmZNhRg+jyKXSWaXcjDf24 /c9Q== X-Forwarded-Encrypted: i=1; AJvYcCW3nyNExpqVyRj3m6YQdLjN/lZnP5j+WeOe/gpud71BnlQsmuEvz9WL1JbyfXYnCLX5UvTk9GAOlSQiMuw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr9O6Br2/Ko7AThI01LSFuF/MUXZSr3zCTNzlDD/cWvffR3hsv iu/Gm2I3dg6DXKVPc+9fO+QKb5y0piD3vkKTDbWoKBxBc9tSablXXOoq X-Gm-Gg: ATEYQzxHJwXzN59T+OjgJugzVTw/hagcjGoLZZdoeMSQHc7/r21RFBRtGFPBSDEC9Lr 2+WE8a7d9GHiP/Z70RUjgbsgG4cpdSpYT5F/4JHCzhh6xm9LxSk6KFHeb6Uhc86rhVTHHQw+5II VZdRMGV1PMdfs+wu9htFFuqYhcM5J5dxaUcuvvdI84w6C9Jsfjh/UhkXwIJe0tpFJdY01IYnrkQ AKQEPr6NTjIcJGI0oggNFj1MDIMT0cA7MGBMkThzt08N2VUVN9L0+UCM4ippjmPi+D7+SSeiTOi 5MBIcw7/k92/3YB8wVgyu13o8wURhgnoznaWjHQ7rBPqGCH0/ZqWWEmwbZ6iwVHzogCAj5qt5dq DLKrQNIuhFm7mUAY49Ic2n2caBBZuJa4EU6xupA1ExOuHTMTtkYLtqU0SVSvlBzH4fx8VgLwBxw == X-Received: by 2002:a05:600c:8b30:b0:483:afbb:a086 with SMTP id 5b1f17b1804b1-483c9c0e31amr163966695e9.29.1772399257214; Sun, 01 Mar 2026 13:07:37 -0800 (PST) Received: from kimsufi.. ([2001:41d0:303:6f54::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f26d7sm378556845e9.3.2026.03.01.13.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 13:07:36 -0800 (PST) From: Ruslan Valiyev To: syzbot+639ebc6ec75e96674741@syzkaller.appspotmail.com, "Daniel W . S . Almeida" , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzkaller-bugs@googlegroups.com, Ruslan Valiyev Subject: [PATCH] media: vidtv: fix nfeeds state corruption on start_streaming failure Date: Sun, 1 Mar 2026 21:07:35 +0000 Message-ID: <20260301210735.334110-1-linuxoid@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <698aaf77.050a0220.1ad825.0033.GAE@google.com> References: <698aaf77.050a0220.1ad825.0033.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit syzbot reported a memory leak in vidtv_psi_service_desc_init [1]. When vidtv_start_streaming() fails inside vidtv_start_feed(), the nfeeds counter is left incremented even though no feed was actually started. This corrupts the driver state: subsequent start_feed calls see nfeeds > 1 and skip starting the mux, while stop_feed calls eventually try to stop a non-existent stream. This state corruption can also lead to memory leaks, since the mux and channel resources may be partially allocated during a failed start_streaming but never cleaned up, as the stop path finds dvb->streaming == false and returns early. Fix by decrementing nfeeds back when start_streaming fails, keeping the counter in sync with the actual number of active feeds. [1] BUG: memory leak unreferenced object 0xffff888145b50820 (size 32): comm "syz.0.17", pid 6068, jiffies 4294944486 backtrace (crc 90a0c7d4): vidtv_psi_service_desc_init+0x74/0x1b0 drivers/media/test-drivers/vidtv/vidtv_psi.c:288 vidtv_channel_s302m_init+0xb1/0x2a0 drivers/media/test-drivers/vidtv/vidtv_channel.c:83 vidtv_channels_init+0x1b/0x40 drivers/media/test-drivers/vidtv/vidtv_channel.c:524 vidtv_mux_init+0x516/0xbe0 drivers/media/test-drivers/vidtv/vidtv_mux.c:518 vidtv_start_streaming drivers/media/test-drivers/vidtv/vidtv_bridge.c:194 [inline] vidtv_start_feed+0x33e/0x4d0 drivers/media/test-drivers/vidtv/vidtv_bridge.c:239 Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Reported-by: syzbot+639ebc6ec75e96674741@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=639ebc6ec75e96674741 Signed-off-by: Ruslan Valiyev --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vidtv/vidtv_bridge.c b/drivers/media/test-drivers/vidtv/vidtv_bridge.c index b6203e10e37aa..a8a76434989c2 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -237,8 +237,10 @@ static int vidtv_start_feed(struct dvb_demux_feed *feed) if (dvb->nfeeds == 1) { ret = vidtv_start_streaming(dvb); - if (ret < 0) + if (ret < 0) { + dvb->nfeeds--; rc = ret; + } } mutex_unlock(&dvb->feed_lock); -- 2.43.0