From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B7D27FD52 for ; Sun, 1 Mar 2026 21:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401702; cv=none; b=hsOaKTdVPM8nhwWPQm4qq8wbR6Qpv7Ur7/jM7T4zfwZvktemX8xuULb6iWN5wtWYOrtSzAK7mweF3808uBe6GEr9XpybISR3DJCFNv1kGJXwbJ00uqbelC0HFIf+XPwxGu3Oezw86fG5410hqe/OxuqvqKLwkcruXP2t8KVmzpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401702; c=relaxed/simple; bh=LUy1QzCzZ2Vt49l4Ogih2TytM0hTHyN3IaBeGxYcOAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F+Tf7d0+Jl9Dz01P2VkyIWG5FHMUhrdHbWKZt1lv8aAtoS+8YZyMRMWLGC/ZfteUaLek7YuVlt1jjFIRu+fawDiBFbp3Rpj2GaK1LnvsIqysvHZW+t3RcJzOD3ffqlNRDMcRJt85g+VdW346Q8BhdMVDedP4aN+NNKnfBDCGUHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=glu6Gq9Y; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="glu6Gq9Y" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-899c3441177so66130216d6.0 for ; Sun, 01 Mar 2026 13:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772401699; x=1773006499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WgQTXI0MuVbXZoitGibu+W9qoch/e7f+GVRyujwVuMw=; b=glu6Gq9YhC2AMDv3rCMW4XPmV25oMTaNQTtMYdR9BJYYiYJNMTS7yGMtbGUdNadv8B rIU2ry4AJMux8GhqhFxoF3QUxDgSZPYNJ/lJbqL3bsUaldKgzMlpiZZl6qWaVT1qjMxs azIH0crd5ile6Pyfz+pfysGBhkYWHwbXOlh0ew06peq67q7qwnxVCWMnuHmCNkZhuJRH THJ1djnFcs2yJEaRRKhRzOqXnKES3RzhS88matq60/8ZKUbm7BYME77hKMud87kTlYod RzwvYzBAuQHtQhNbsBGeBqI9Ehp+Zj2bwV33YDA5tZjc2ypq/1OFSw+6QHohq2eXWC1e Sk/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772401699; x=1773006499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WgQTXI0MuVbXZoitGibu+W9qoch/e7f+GVRyujwVuMw=; b=IynlZMKwgq47xnptuqWDVjrxm4Qc+YGJV9Wc2xYueprXTyDX/drQ/9WhNeY/LFazck qSu1u3dYHxxKAQJEepfnQ/TKWAPgHEbljn0FX2dN6m8+inmsGYc3eScMngBpPr6IF9EI dPh+bQR7nVAltCMV4DRt3em0ZRfW0cDPpX5Zw6gxYipf0UCRwrN5XAHO563IC0YkHpA4 AznjA9qlLjDH2ygmndgK1dyCFMPaYwhngBS/kMD6RSlaZGUxnX9lCvRVjd2jVxS33kJg 2R/T6uoN519lq6TcnWJpy+r+QISsGYPTOr3cMRcnRUFf+Ali+xfXupi7OYehBtAqQ1To gg4A== X-Forwarded-Encrypted: i=1; AJvYcCX5d9SflKRygp3XTxF9QATsONCrupApp6I5VkPDIGOXNlB4eg5f3JCvKsolq5MGovjzHO+B0dcfK8qyEjQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1WdkQgb0lCtSrp2CmIEQxJMltg7/6/EuOqYmpooKbczTZMQmQ vEunb3WBFe0/FtOJEhvvBWyIBSUEnE4qjg/8peQv5D+iOpFkk2aICuSQ X-Gm-Gg: ATEYQzwGBfdJyHnKmjq4WrtZ98xVIiB6Q15t9CixzPkahhFRjhLaW8t+Tm/eF3LaX/y r2gn8wWZFf3N0BWonJy4YCE6fuGN2OUKSSJL35pyhE1BUi4nBKMZ61+dfpO5u4zSq6mqLoC1iOB CB/8RhEbgwU2BJkPYrZ/4fA/cnQwWF6kTm3RS8T9chOZcpaG6PUMu7Zc/DD+U1jRF9UQ33jg7U+ nZqz0Ft4mcJEBp3+/sa4zO1HrtSvgExm4VyCCeuB3LYuaRTsjNPV2v9adtvF2VMZCz+2QhGTATv L5L6LTVgtFAsTIzosWPlXsSo080/hSzjGMl2aILwQGJp5clw5S7g4Lfh0TLOWMUyeD3MRiO0JDG HE434aFv4q1Lixg8E/J4cP5TbIwjgnw8XrFwjhd6EZXiwsy6lyavhf4nmmWB26ganK1QeeH6s/W nwRxh9DNeyNQPNBGzv1zrHcugxmHNB2bRn0tRxSQySMM+lx0D0+KkDyaACAdznpltUCCgQ4QfPu OOTJO8T4HoJ9Oc= X-Received: by 2002:a05:6214:21cd:b0:897:306d:98c1 with SMTP id 6a1803df08f44-899d1e3dc5emr158000926d6.34.1772401699349; Sun, 01 Mar 2026 13:48:19 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6f948dsm1006700085a.30.2026.03.01.13.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 13:48:18 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman , Ovidiu Panait Cc: Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2 02/10] staging: axis-fifo: remove redundant goto end Date: Sun, 1 Mar 2026 21:48:07 +0000 Message-ID: <20260301214815.2628942-2-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301214815.2628942-1-objecting@objecting.org> References: <20260301214815.2628942-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Josh Law Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index aac2c58ef9b3..d83a0fd5b231 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) &value); if (ret) { dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n"); - goto end; + return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width", &value); if (ret) { dev_err(fifo->dt_device, "missing xlnx,axi-str-txd-tdata-width property\n"); - goto end; + return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", @@ -418,7 +418,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", @@ -426,7 +426,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,use-rx-data", @@ -434,7 +434,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n"); ret = -EIO; - goto end; + return ret; } ret = of_property_read_u32(node, "xlnx,use-tx-data", @@ -442,10 +442,9 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n"); ret = -EIO; - goto end; + return ret; } -end: return ret; } -- 2.43.0