From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 655DE2F28FF for ; Sun, 1 Mar 2026 21:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401706; cv=none; b=LCmHNDgthhW55y/bH8E/F0AtCTN2lbdlzth2W8i1ix/eyLIzq+lEb3UsKnQUPHSUT5P6toewXkd8N+zNFGQ5se5PF9JcruvNFgwEYU3agY+kumbRGgbWoHhwrYKiMdyrd4z+2Ul/vSwlDw+L48NEOxUgv67SHnyZgKrvJf8scNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401706; c=relaxed/simple; bh=EEExisL9ZxFMSVway9coz0e07ZbRvOOtunDKAUDdE+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vGQnTSNc/EDCWDgFtD0Md+18vKpS5SwyXuyB1n2iLC3qHmid7l9kSM+u4brA7qQfAjAJU9eDwiFCavxT1gcQ8zk+TRFrJLxjPwSwepFsCiMv+o+RDjhSwib0RwphVd3svgJz8d3mdCgrKMEuD47gnglI2sAlMwuKyVjQ6JRCEJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VTslST5r; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VTslST5r" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-899a5cb04f9so49843626d6.2 for ; Sun, 01 Mar 2026 13:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772401704; x=1773006504; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=75IgDQs0oEmkLuL7YnbfeaPuMP52JNoBZmKkzLew9AY=; b=VTslST5rkYF1g8xX1qJpDehQzV/yBtVkEmJdcfEbOjSuZmD5S57mk2GesspI0+EdCu BlmOEbmjgN2+nDfEGyT+qyJY7NlWF23/NzhzCZ/CmWGDCIWFCVfChEV6TLa1c6dfjlFY iSqUpnde4cZLvWoWMKKD4dT/o5alCz9/6aIgO20vsErfmOiBc/hD07X8MEkxfR9W6zFz EFIMI2JcNN+Gz5Ms+/QM3n34icp0i48+fYs++Zapb1JVBhYtgTjRtWpwf1Nm3GI/Iliz e2QIBD2HGMNGR475X5fgrd//XHLrVJKa/EgrMu0UQ7RcIUHtjF4k3/QflGxXbkp6dHlX 2n4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772401704; x=1773006504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=75IgDQs0oEmkLuL7YnbfeaPuMP52JNoBZmKkzLew9AY=; b=Y3RIxse9SAuf3p6rPRCdkpevMyhSwLpzCNkMGTtUCLwRQlg6zRSs2NXnf83xjiUI5b 4Wn3oGDm4bAwdc8LuUJp8UxMJs6urZcWjY0zOrcsOxnj2DcXLcwdZaL3Re+vlnkzENPo rzHdHm3tLNLYbfUbRh1RQahlSFuf5/d4RiO5wET1rpvsiPmsUhVLsRiLuaT7O2dE8Ep7 OfSlXkIaDyVpVwjV3mDo8P9VBOLdj4tOxcbRzyLIMK+yxl4/QfOq+EFR5AhbGOjV6EGS lVvivsB5UskS7ImMuUj51ml6GNmI/S6WT2NiB7MEh5FCbR5X/XScZQd53NaTlq9n0hEp bqJg== X-Forwarded-Encrypted: i=1; AJvYcCU3QB8ew3EVo+jCVKRud3A+yRtlxUVZabRdrggsz4dE0+bW3kWaFjJLlqH7J9e1ccNu/KI6rN3Zxybn+cY=@vger.kernel.org X-Gm-Message-State: AOJu0YyzdyESfmAtS1YySFxwpgiR64R8RuDYp8NJhACGHiXyRrHgowAw uc6RJJ9HAkMdv6ilzsWMOaMT8M/6oK2iRuNQZTm6DpQ0i6mKWXGUenbn X-Gm-Gg: ATEYQzyVZmQHwfNNabZlg/RCoWT0doBbIl1hM3EX/7LogZnlX+Cfu2wnIls+hoqebn3 Rk0NkTI4XQ0FdWpl3/ummjtvslkt1NR3z6l1I5j1GIp98I+OuA60W3HaIzrBVF4WarfaRDeHkHP IIRMyB8o7aP5AQTkL0IvV6fOENSMgQzg3O1sRpXqYd2/OukolgXMMuQSusoi/y/xCEATL2nr9ui 8q/Pyb9fQevcwUb0iM+qNIMSJ0kqq/FuLkQHtxTFm7rKrkWVGMA+34NSHpvKPtjRhZAdsgW8kfE 310blNY83Nu72YS813aUQAS5fHpCxCIiJGlz4SEXqI4wywpW66qzrEufD7kuOTOMwrTTvntuRWs S/MD2Fr9V3xCrpCNvorKWzdRj6oTDePuoOfdfkesNGrRpVvIm+K8wqRYET5j58kfTOEkHp6boxX fXKwAbR/hwr8xdjz6iqTNTuJE89mrXSLh23qOYTqzD+lgy3vRy3w11+13pOf3nVHqJ8c0ys7rvD sE/ X-Received: by 2002:a05:6214:2482:b0:899:f9f5:9798 with SMTP id 6a1803df08f44-899f9f5b2f7mr26197376d6.43.1772401704350; Sun, 01 Mar 2026 13:48:24 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6f948dsm1006700085a.30.2026.03.01.13.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 13:48:23 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman , Ovidiu Panait Cc: Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2 04/10] staging: axis-fifo: use dev_err_probe() for IRQ error handling Date: Sun, 1 Mar 2026 21:48:09 +0000 Message-ID: <20260301214815.2628942-4-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301214815.2628942-1-objecting@objecting.org> References: <20260301214815.2628942-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Josh Law Simplify the error handling in the probe function by using dev_err_probe() instead of dev_err() when devm_request_irq() fails. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index fc8e35696b31..28268881cda2 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -484,11 +484,9 @@ static int axis_fifo_probe(struct platform_device *pdev) rc = devm_request_irq(fifo->dt_device, irq, &axis_fifo_irq, 0, DRIVER_NAME, fifo); - if (rc) { - dev_err(fifo->dt_device, "couldn't allocate interrupt %i\n", - irq); - return rc; - } + if (rc) + return dev_err_probe(fifo->dt_device, rc, + "couldn't allocate interrupt %i\n", irq); fifo->id = ida_alloc(&axis_fifo_ida, GFP_KERNEL); if (fifo->id < 0) -- 2.43.0